Expose double signer implementation #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* finished code with logs * Update consensus/polybft/transport.go Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * delete some logs * Update consensus/polybft/transport.go Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * fix unused imports * fix wrong logger call --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
Stefan-Ethernal
force-pushed
the
feat/double-signer-impl
branch
from
12f0a63
to
84ceb58
Compare
Credits to @vcastellm! 🙂 |
Stefan-Ethernal
force-pushed
the
feat/double-signer-impl
branch
from
0543388
to
1a319ba
Compare
Stefan-Ethernal
force-pushed
the
feat/double-signer-impl
branch
from
1a319ba
to
7e00917
Compare
Stefan-Ethernal
changed the title
jelacamarko
approved these changes
Sep 7, 2023
stana-miric
approved these changes
Sep 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides double signer implementation, which is used to test the slashing feature. It relies on build tags to build honest and double signer implementations and removes byzantine binary from the repository.
doubleSigner build tag is introduced, so whenever we want to build a double signer implementation, we should run the following command:
go build -tags doubleSigner -o artifacts/polygon-edge-double-signer .Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it