Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed ibft tests (#1876) #1877

Merged
merged 4 commits into from
Sep 6, 2023
Merged

fixed ibft tests (#1876) #1877

merged 4 commits into from
Sep 6, 2023

Conversation

rachit77
Copy link
Contributor

@rachit77 rachit77 commented Sep 6, 2023

Description

This PR fix the failing IBFT tests in nightly build

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@rachit77 rachit77 added the bug fix Functionality that fixes a bug label Sep 6, 2023
@rachit77 rachit77 self-assigned this Sep 6, 2023
vcastellm
vcastellm approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachit77 rachit77 merged commit 52115cc into develop Sep 6, 2023
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@rachit77 rachit77

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rachit77 @vcastellm @Stefan-Ethernal