Index methods by signature when there is ambiguity #1880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of #1854 and it generates SC bindings in a way that they index ABI methods by signature in case the function was resolved by signature, instead of by its name (e.g.
ChildERC20PredicateAccessList
defines two functions with the same name but different params, which caused us some troubles in the past).Changes include
Checklist
Testing
Manual tests
ChildERC20PredicateAccessList.json
artifact within the core-contracts, make sure that initialize function with 5 parameters parameters is in the first place (before the one with 8 of them, that is initializing access-list configuration)make generate-smart-contract-bindings
TestE2E_Bridge_Transfers_AccessLists
and make sure it is executed successfully (namely it does not fail after first withdrawal being made)