Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index methods by signature when there is ambiguity #1880

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Sep 6, 2023

Description

This PR is a continuation of #1854 and it generates SC bindings in a way that they index ABI methods by signature in case the function was resolved by signature, instead of by its name (e.g. ChildERC20PredicateAccessList defines two functions with the same name but different params, which caused us some troubles in the past).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

  1. In the ChildERC20PredicateAccessList.json artifact within the core-contracts, make sure that initialize function with 5 parameters parameters is in the first place (before the one with 8 of them, that is initializing access-list configuration)
  2. Generate artifacts and bindings in the Edge, by running make generate-smart-contract-bindings
  3. Run TestE2E_Bridge_Transfers_AccessLists and make sure it is executed successfully (namely it does not fail after first withdrawal being made)

@Stefan-Ethernal Stefan-Ethernal self-assigned this Sep 6, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Sep 6, 2023
@Stefan-Ethernal Stefan-Ethernal requested review from a team and begmaroman September 6, 2023 13:55
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review September 6, 2023 13:58
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-825-initialize-child-erc-20-predicate-acl-fn-binding-encode-params-issue branch from 0962861 to 05fb779 Compare September 6, 2023 14:25
@Stefan-Ethernal Stefan-Ethernal merged commit c3da0d4 into develop Sep 7, 2023
7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-825-initialize-child-erc-20-predicate-acl-fn-binding-encode-params-issue branch September 7, 2023 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants