Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly build script by providing governor-admin flag #1882

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix nightly build script by providing governor-admin flag #1882

merged 1 commit into from
Sep 6, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Sep 6, 2023 •
edited

Description

Fix nightly build GH workflow, by providing governor-admin flag, which is obligatory to the genesis command.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal requested a review from a team September 6, 2023 14:34
@Stefan-Ethernal Stefan-Ethernal self-assigned this Sep 6, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Sep 6, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review September 6, 2023 14:34
@Stefan-Ethernal Stefan-Ethernal requested a review from a team September 6, 2023 14:40
@vcastellm vcastellm temporarily deployed to devnet September 6, 2023 15:23 — with GitHub Actions Inactive
@vcastellm vcastellm temporarily deployed to devnet September 6, 2023 16:46 — with GitHub Actions Inactive
@vcastellm vcastellm temporarily deployed to devnet September 6, 2023 17:08 — with GitHub Actions Inactive
@vcastellm vcastellm temporarily deployed to devnet September 6, 2023 17:13 — with GitHub Actions Inactive
@vcastellm vcastellm temporarily deployed to devnet September 6, 2023 17:18 — with GitHub Actions Inactive
@vcastellm vcastellm merged commit b467a12 into develop Sep 6, 2023
13 of 14 checks passed
@vcastellm vcastellm deleted the fix/nightly-script-governor-admin branch September 6, 2023 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@gatsbyz gatsbyz Awaiting requested review from gatsbyz

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stefan-Ethernal @vcastellm @goran-ethernal