-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM-831 Implement state sync relayer without blocktracker #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorcrevar
force-pushed
the
feature/state_sync_relayer_refactor
branch
5 times, most recently
from
September 8, 2023 15:11
dd821d3
to
2eb8315
Compare
goran-ethernal
force-pushed
the
feature/state_sync_relayer_refactor
branch
from
October 4, 2023 08:56
3012cb9
to
55e704e
Compare
igorcrevar
force-pushed
the
feature/state_sync_relayer_refactor
branch
10 times, most recently
from
October 10, 2023 14:49
1b32fe2
to
7d4c792
Compare
igorcrevar
force-pushed
the
feature/state_sync_relayer_refactor
branch
4 times, most recently
from
October 13, 2023 11:59
f5cad29
to
fe8a08c
Compare
goran-ethernal
force-pushed
the
feature/state_sync_relayer_refactor
branch
from
October 16, 2023 14:35
047c3c9
to
94e0f58
Compare
goran-ethernal
approved these changes
Oct 17, 2023
dusan-maksimovic
approved these changes
Oct 17, 2023
Stefan-Ethernal
approved these changes
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
State sync relayer should not depend on blocktracker but should be part of consensus runtime like all the other similar parts.
Consensus runtime should call state sync relayer
PostBlock(req *common.PostBlockRequest) error
every time new block is inserted. State sync relayer should parse all the events and should submit transaction for each of those. It also internally remembers next event ID and next block number that should be processed (because sometimes something can go wrong).Flag
--relayer-poll-interval
will be removed because its not used anymoreChanges include
Checklist
Testing