Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing tx hash fork #1904

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Removing tx hash fork #1904

merged 2 commits into from
Sep 13, 2023

Conversation

igorcrevar
Copy link
Contributor

Description

removing fork which is introduced to have different hashing approaches for transaction

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Sep 11, 2023
@igorcrevar igorcrevar requested a review from a team September 11, 2023 09:50
@igorcrevar igorcrevar self-assigned this Sep 11, 2023
@igorcrevar igorcrevar marked this pull request as ready for review September 11, 2023 12:08
dusan-maksimovic
dusan-maksimovic approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@dusan-maksimovic dusan-maksimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not going to remove blockNumber from ComputeHash() everything looks fine. If we are- it needs additional cleanup.

@Nemanja0x Nemanja0x self-requested a review September 12, 2023 09:22
@igorcrevar igorcrevar merged commit dcfc044 into develop Sep 13, 2023
5 of 6 checks passed
@igorcrevar igorcrevar deleted the feature/remove_tx_hash branch September 13, 2023 09:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@stana-miric stana-miric stana-miric approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@igorcrevar igorcrevar

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@igorcrevar @Nemanja0x @Stefan-Ethernal @dusan-maksimovic @stana-miric @goran-ethernal