Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up root chain contracts deployment #1906

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Speed up root chain contracts deployment #1906

merged 2 commits into from
Sep 13, 2023

Conversation

dusan-maksimovic
Copy link
Contributor

Description

Results write lock is now held shorter, so more things can be done in parallel than it was the case before.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@dusan-maksimovic dusan-maksimovic added the bug fix Functionality that fixes a bug label Sep 12, 2023
@dusan-maksimovic dusan-maksimovic requested a review from a team September 12, 2023 12:14
@dusan-maksimovic dusan-maksimovic self-assigned this Sep 12, 2023
Stefan-Ethernal
Stefan-Ethernal approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the comment, LGTM.

command/rootchain/deploy/deploy.go Outdated Show resolved Hide resolved
@dusan-maksimovic @Stefan-Ethernal
Update command/rootchain/deploy/deploy.go
1ff2656 
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
@dusan-maksimovic dusan-maksimovic merged commit 182aadd into develop Sep 13, 2023
7 checks passed
@dusan-maksimovic dusan-maksimovic deleted the EVM-834-improve-e-2-e-tests-speed branch September 13, 2023 07:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@dusan-maksimovic dusan-maksimovic

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dusan-maksimovic @Nemanja0x @Stefan-Ethernal