Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eth_FeeHistory unmarshal input params error #1917

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix eth_FeeHistory unmarshal input params error #1917

merged 1 commit into from
Sep 19, 2023

Conversation

dusan-maksimovic
Copy link
Contributor

@dusan-maksimovic dusan-maksimovic commented Sep 18, 2023 •
edited by Stefan-Ethernal

Description

This PR fixes issue 776. First parameter of FeeHistory() method is argUint64, which could not be unmarshalled from raw JSON since there was no UnmarshalJSON() method implemented for it.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@dusan-maksimovic dusan-maksimovic added the bug fix Functionality that fixes a bug label Sep 18, 2023
@dusan-maksimovic dusan-maksimovic requested a review from a team September 18, 2023 14:49
@dusan-maksimovic dusan-maksimovic self-assigned this Sep 18, 2023
Stefan-Ethernal
Stefan-Ethernal approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stefan-Ethernal Stefan-Ethernal changed the title Fix Eth.FeeHistory() unmarshal input params error Fix eth_FeeHistory unmarshal input params error Sep 19, 2023
vcastellm
vcastellm approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stefan-Ethernal Stefan-Ethernal merged commit d632735 into develop Sep 19, 2023
6 of 7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-776-eth-fee-history-rpc-endpoint-does-not-manage-to-unmarshal-input-params branch September 19, 2023 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@dusan-maksimovic dusan-maksimovic

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dusan-maksimovic @vcastellm @igorcrevar @Stefan-Ethernal