Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide race and shuffle flags when running unit tests #1925

Merged
merged 24 commits into from
Oct 2, 2023
Merged

Provide race and shuffle flags when running unit tests #1925

merged 24 commits into from
Oct 2, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Sep 21, 2023 •
edited

Description

This PR provides race and shuffle flags when running unit tests to discover any outstanding race conditions and potential hidden dependencies between different tests (respectively).

Also, fix race conditions in unit tests that are reported by race flag.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-839-run-unit-tests-with-race-detection-and-shuffle-flags branch 3 times, most recently from 85f5ef7 to b1e1351 Compare September 27, 2023 08:34
@Stefan-Ethernal Stefan-Ethernal self-assigned this Sep 28, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Sep 28, 2023
@Stefan-Ethernal
Provide race and shuffle flags
7c09b60
@Stefan-Ethernal
Fix race condition in TestBlockchain_VerifyBlockParent test
9e0a197
@Stefan-Ethernal
Fix race conditions in Test_TxPool_validateTx
6f6bf1d
@Stefan-Ethernal
Capture loop variable
1f9b8d2
@Stefan-Ethernal
Fix TestAddTxsInOrder
a614861
@Stefan-Ethernal
Linter fixes
bb755d2
@Stefan-Ethernal
Fix TestBlockchain_VerifyBlockBody race conditions
83f5dfe
@Stefan-Ethernal
Fix Test_VerifySignature_NegativeCases
0959da4
@Stefan-Ethernal
Fix TestDropKnownGossipTx
f64ced2
@Stefan-Ethernal
Retrieve tx hash in a thread safe manner
760cfe5
@Stefan-Ethernal
Fix TestStatusPubSub race condition
546c352
@Stefan-Ethernal
Fix peers_test
3d2f537
@Stefan-Ethernal
Fix Test_newTracer
9ad9fa6
@Stefan-Ethernal
Provide race flag when building binary and running fuzz tests
dc33678
@Stefan-Ethernal
Fix data races in fund and deposit_erc20 commands
de4b7c2
@Stefan-Ethernal
Fix TestEventSubscription_ProcessedEvents
d0fe113
@Stefan-Ethernal
Fix TestSimpleGossip (hopefully)
8e1376e
@Stefan-Ethernal
Fix data race in e2e tests (txRelayer.SendTransactionLocal)
e62c859
@Stefan-Ethernal
Avoid race conditions in ibft/signer package
7c100b9
@Stefan-Ethernal
Increase timeout in TestEventSubscription_ProcessedEvents
b389510
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-839-run-unit-tests-with-race-detection-and-shuffle-flags branch 2 times, most recently from 0f36906 to b389510 Compare September 29, 2023 06:21
@Stefan-Ethernal Stefan-Ethernal requested a review from a team September 29, 2023 10:31
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review September 29, 2023 10:31
vcastellm
vcastellm approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stefan-Ethernal Stefan-Ethernal merged commit 12d38b8 into develop Oct 2, 2023
7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-839-run-unit-tests-with-race-detection-and-shuffle-flags branch October 2, 2023 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@jelacamarko jelacamarko jelacamarko approved these changes

@stana-miric stana-miric stana-miric approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Stefan-Ethernal @vcastellm @igorcrevar @jelacamarko @stana-miric