Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-843 Fix block post processing #1928

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

igorcrevar
Copy link
Contributor

Description

If node is stopped before stake manager has updated its internal state, there could be problems with consensus after node starts again. So, to prevent this, stake manager should update its internal state when node is started again.

Stake sync manager and checkpoint manager do not need to update their states because they do not have anything of importance for go-ibft consensus.
On the other hand, governance manager does have and that logic should be implemented if we decide to return back governance implementation

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Sep 21, 2023
@igorcrevar igorcrevar requested a review from a team September 21, 2023 15:04
@igorcrevar igorcrevar self-assigned this Sep 21, 2023
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from nitpicks.

consensus/polybft/stake_manager.go Outdated Show resolved Hide resolved
consensus/polybft/stake_manager.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from nitpicks.

@igorcrevar igorcrevar merged commit 9c9af49 into develop Sep 25, 2023
6 checks passed
@igorcrevar igorcrevar deleted the feature/EVM-843-fix-block-post-processing branch September 25, 2023 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants