Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base fee change denominator as genesis parameter #1934

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Base fee change denominator as genesis parameter #1934

merged 5 commits into from
Sep 29, 2023

Conversation

jelacamarko
Copy link
Contributor

@jelacamarko jelacamarko commented Sep 26, 2023 •
edited

Description

Base fee change denominator is added in genesis command

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@jelacamarko jelacamarko force-pushed the evm-833-base-fee-change-denom-as-genesis branch from 4a9a9bc to e83a108 Compare September 27, 2023 12:31
@jelacamarko jelacamarko marked this pull request as ready for review September 27, 2023 14:33
@jelacamarko jelacamarko requested a review from a team September 27, 2023 14:33
@jelacamarko jelacamarko self-assigned this Sep 27, 2023
vcastellm
vcastellm approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelacamarko jelacamarko merged commit d4537fe into develop Sep 29, 2023
7 checks passed
@jelacamarko jelacamarko deleted the evm-833-base-fee-change-denom-as-genesis branch September 29, 2023 11:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@stana-miric stana-miric stana-miric approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@jelacamarko jelacamarko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jelacamarko @vcastellm @Stefan-Ethernal @dusan-maksimovic @stana-miric @goran-ethernal