Default value of JSON RPC flag in commands #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
approved these changes
Sep 27, 2023
|
Probably a good idea to validate JSON RPC value in bridge commands as well (https://github.com/0xPolygon/polygon-edge/blob/EVM-839-run-unit-tests-with-race-detection-and-shuffle-flags/command/bridge/common/params.go#L74C1-L79)? |
Stefan-Ethernal
approved these changes
Sep 27, 2023
|
@Stefan-Ethernal Agreed, I added this validation there as well. Please take a look. |
Looks good 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue 1649.
Default value of --jsonrpc flag changed from 0.0.0.0:8545 (which doesn't work) to http://0.0.0.0:8545.
Added validation of the provided value in commands where it was missing.
Changes include
Checklist
Testing