Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundant queue length check in accountQueue.peek() function #1952

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Removed redundant queue length check in accountQueue.peek() function #1952

merged 1 commit into from
Oct 2, 2023

Conversation

dusan-maksimovic
Copy link
Contributor

Description

The check is redundant since it is checked again during q.queue.Peek() execution. This PR closes issue #1861.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@dusan-maksimovic dusan-maksimovic added the bug fix Functionality that fixes a bug label Oct 2, 2023
@dusan-maksimovic dusan-maksimovic requested a review from a team October 2, 2023 07:16
@dusan-maksimovic dusan-maksimovic self-assigned this Oct 2, 2023
@dusan-maksimovic dusan-maksimovic linked an issue Oct 2, 2023 that may be closed by this pull request
Fix peek function of accountQueue in txpool #1861
Closed
@Stefan-Ethernal Stefan-Ethernal requested a review from a team October 2, 2023 07:26
@dusan-maksimovic dusan-maksimovic merged commit 9e55557 into develop Oct 2, 2023
7 checks passed
@dusan-maksimovic dusan-maksimovic deleted the EVM-851-fix-peek-function-of-account-queue-in-txpool branch October 2, 2023 09:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igorcrevar igorcrevar igorcrevar approved these changes

@rachit77 rachit77 rachit77 approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@stana-miric stana-miric stana-miric approved these changes

Assignees

@dusan-maksimovic dusan-maksimovic

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix peek function of accountQueue in txpool
5 participants
@dusan-maksimovic @igorcrevar @rachit77 @Stefan-Ethernal @stana-miric