Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bridge e2e tests for transferring tokens #1953

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

Nemanja0x
Copy link
Contributor

Description

Fix e2e tests for transferring ERC1155 and ERC721.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Manually start e2e tests.

@Nemanja0x Nemanja0x added the bug fix Functionality that fixes a bug label Oct 2, 2023
@Nemanja0x Nemanja0x self-assigned this Oct 2, 2023
Copy link
Contributor

@igorcrevar igorcrevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure should we check for valid state sync result logs with something like this:

if i == numberOfAttempts-1 {
			checkStateSyncResultLogs(t, logs, 2)

			break
		} else if areStateSyncResultLogsGood(logs, 2) {
			break
		}

otherwise good

e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/bridge_test.go Show resolved Hide resolved
@Stefan-Ethernal Stefan-Ethernal changed the title Fix e2e tests for transferring tokens Fix bridge e2e tests for transferring tokens Oct 3, 2023
@Nemanja0x Nemanja0x merged commit 4d4d699 into develop Oct 3, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2023
@igorcrevar igorcrevar deleted the e2eBridgeTransferFixes branch October 3, 2023 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants