-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IBFT E2E tests #1960
Merged
Stefan-Ethernal
merged 9 commits into
develop
from
EVM-856-fix-test-tx-pool-recoverable-error-ibft-e-2-e-test
Oct 6, 2023
Merged
Fix IBFT E2E tests #1960
Stefan-Ethernal
merged 9 commits into
develop
from
EVM-856-fix-test-tx-pool-recoverable-error-ibft-e-2-e-test
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stana-miric
approved these changes
Oct 5, 2023
Stefan-Ethernal
changed the title
Fix TestTxPool_RecoverableError E2E test
Fix IBFT E2E test
Oct 5, 2023
rachit77
approved these changes
Oct 5, 2023
Stefan-Ethernal
force-pushed
the
EVM-856-fix-test-tx-pool-recoverable-error-ibft-e-2-e-test
branch
from
October 5, 2023 14:26
c160cd2
to
40e8d0a
Compare
goran-ethernal
approved these changes
Oct 6, 2023
Stefan-Ethernal
deleted the
EVM-856-fix-test-tx-pool-recoverable-error-ibft-e-2-e-test
branch
October 6, 2023 11:52
vcastellm
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
TestTxPool_RecoverableError
test, by bumping transactions' gas price above the base fee.Also, a couple of more failing tests regarding IBFT Stake and Unstake were failing, because fees were checked for EVM messages, that were representing contract calls. Those should be free of charge.
Changes include
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it