Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IBFT E2E tests #1960

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Oct 5, 2023

Description

Fixes TestTxPool_RecoverableError test, by bumping transactions' gas price above the base fee.
Also, a couple of more failing tests regarding IBFT Stake and Unstake were failing, because fees were checked for EVM messages, that were representing contract calls. Those should be free of charge.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Oct 5, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Oct 5, 2023
@Stefan-Ethernal Stefan-Ethernal requested review from a team and rachit77 October 5, 2023 06:23
@Stefan-Ethernal Stefan-Ethernal marked this pull request as draft October 5, 2023 07:41
@Stefan-Ethernal Stefan-Ethernal changed the title Fix TestTxPool_RecoverableError E2E test Fix IBFT E2E test Oct 5, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Fix IBFT E2E test Fix IBFT E2E tests Oct 5, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review October 5, 2023 13:35
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-856-fix-test-tx-pool-recoverable-error-ibft-e-2-e-test branch from c160cd2 to 40e8d0a Compare October 5, 2023 14:26
@Stefan-Ethernal Stefan-Ethernal merged commit 6a724be into develop Oct 6, 2023
8 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-856-fix-test-tx-pool-recoverable-error-ibft-e-2-e-test branch October 6, 2023 11:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants