Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store BLS private key in hex instead of raw big int #1973

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Store BLS private key in hex instead of raw big int #1973

merged 5 commits into from
Oct 11, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Oct 10, 2023 •
edited

Description

Store BLS private key in hex instead of raw big int within both polybft and ibft.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this Oct 10, 2023
@begmaroman begmaroman added the bug Something isn't working label Oct 10, 2023
@begmaroman begmaroman marked this pull request as ready for review October 10, 2023 09:16
vcastellm
vcastellm approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begmaroman begmaroman merged commit e34c65e into develop Oct 11, 2023
10 checks passed
@begmaroman begmaroman deleted the fix/store-bls-as-hex-string branch October 11, 2023 07:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
This was linked to issues Oct 11, 2023
failed to retrieve genesis validators: failed to retrieve bls key: math/big: cannot unmarshal "054838c1aa292d8a7fee4c3ab2baa6c5067708584124931f91361463134b0891" into a *big.Int #1831
Closed
[Docker compose] : ibft consensus failed to run the relayer node #1926
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@stana-miric stana-miric stana-miric approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@begmaroman begmaroman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
5 participants
@begmaroman @vcastellm @Stefan-Ethernal @stana-miric @goran-ethernal