Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxRelayer num retries as an option #1983

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

igorcrevar
Copy link
Contributor

Description

In TxRelayer, there was previously no possibility to specify the number of retries for eth_getTransactionReceipt. When this value is set to -1 (or any other negative number), it means that we do not want to wait for the receipt after SendTransaction or SendTransactionLocal calls.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Oct 12, 2023
@igorcrevar igorcrevar requested a review from a team October 12, 2023 09:23
@igorcrevar igorcrevar self-assigned this Oct 12, 2023
@igorcrevar igorcrevar merged commit 5abd428 into develop Oct 12, 2023
9 checks passed
@igorcrevar igorcrevar deleted the feature/tx_relayer_numretries branch October 12, 2023 10:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants