-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CallTracer implementation for debug endpoints #2001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
force-pushed
the
call-tracer
branch
from
October 20, 2023 12:09
a5d2915
to
bf1c8db
Compare
igorcrevar
reviewed
Oct 23, 2023
igorcrevar
reviewed
Oct 23, 2023
igorcrevar
reviewed
Oct 23, 2023
goran-ethernal
force-pushed
the
call-tracer
branch
from
October 24, 2023 08:15
bf1c8db
to
7cb7be1
Compare
goran-ethernal
force-pushed
the
call-tracer
branch
from
October 24, 2023 08:30
7cb7be1
to
48caef8
Compare
igorcrevar
approved these changes
Oct 24, 2023
Stefan-Ethernal
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
goran-ethernal
force-pushed
the
call-tracer
branch
from
October 26, 2023 09:27
48caef8
to
786e10e
Compare
goran-ethernal
force-pushed
the
call-tracer
branch
from
October 26, 2023 12:45
786e10e
to
c10c000
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
callTracer
fordebug
rpc endpoints.debug_
rpc endpoints config is now expanded withtracer
field to specify which tracer you want to be used. Currently, Edge has two tracers:structTracer
andcallTracer
. If no tracer is specified when calling somedebug
endpoint,structTracer
will be used by default.This implementation is provided by the Gateway.fm friends, who implemented this on their own Edge fork.
How to use
callTracer
eth_getBlockByNumber
returns a result, take some transaction hash fromtransactions
item in json result.debug_traceTransaction
:Changes include
Checklist
Testing