Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert seal parameter removal #2024

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

This PR reverts the removal of the seal parameter from the server command.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal self-assigned this Nov 2, 2023
@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Nov 2, 2023
e2e-polybft/framework/test-cluster.go Outdated Show resolved Hide resolved
Copy link
Contributor

@rachit77 rachit77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/revert-seal-parameter-removal branch from e172f51 to cfc5aed Compare November 2, 2023 12:57
@Stefan-Ethernal Stefan-Ethernal merged commit fa8c777 into develop Nov 2, 2023
7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the fix/revert-seal-parameter-removal branch November 2, 2023 12:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants