-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gas cost overflow for opCall opcode #2026
Conversation
693c03c
to
a23cf1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM have you been able to reproduce?
Only through the unit test (https://github.com/0xPolygon/polygon-edge/pull/2026/files#diff-6f681b2f9f20cf2822bc04c36bd04e44b02b3048a32313ba05b8d90cd2dbacc3R708-R740), and compared that part with Geth implementation. IMO it is pretty much a corner use case (we would need to have a contract, that invokes other contract and providing nearly |
Description
This PR introduces a fix to EVM in terms that it checks for overflows in case of
opCall
gas cost cannot fit uint64. In that case, thegas uint64 overflow
error is returned and execution is halted.Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it