Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final touches to Sonarcloud #2030

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Final touches to Sonarcloud #2030

merged 2 commits into from
Nov 3, 2023

Conversation

vcastellm
Copy link
Contributor

Description

Fix the way we run sonar cloud and clean some vars not longer needed.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@vcastellm vcastellm self-assigned this Nov 3, 2023
@vcastellm vcastellm added the bug fix Functionality that fixes a bug label Nov 3, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vcastellm vcastellm requested a review from a team November 3, 2023 11:03
@vcastellm vcastellm marked this pull request as ready for review November 3, 2023 11:03
@Stefan-Ethernal Stefan-Ethernal requested a review from a team November 3, 2023 11:05
@vcastellm vcastellm merged commit 42ee55f into develop Nov 3, 2023
11 checks passed
@vcastellm vcastellm deleted the vcastellm/sonarcloud branch November 3, 2023 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@vcastellm vcastellm

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcastellm @Stefan-Ethernal @goran-ethernal