Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parts of the trie package #383

Merged
merged 15 commits into from
Feb 2, 2022
Merged

Refactor parts of the trie package #383

merged 15 commits into from
Feb 2, 2022

Conversation

zivkovicmilos
Copy link
Contributor

Description

This PR refactors some legacy parts of the trie package so they're more understandable, and adds coverage tests.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@zivkovicmilos zivkovicmilos added the hotfix Major bug fix that should be merged ASAP label Jan 25, 2022
@dbrajovic dbrajovic marked this pull request as ready for review January 26, 2022 16:38
@zivkovicmilos
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@zivkovicmilos
Copy link
Contributor Author

recheck

@dbrajovic
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 27, 2022
@github-actions
@dbrajovic has signed the CLA from Pull Request #383
e57e050
@dbrajovic
Copy link
Contributor

recheck

Kourin1996
Kourin1996 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@Kourin1996 Kourin1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

0xAleksaOpacic
0xAleksaOpacic approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@lazartravica lazartravica merged commit 2e2fbbb into develop Feb 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2022
@zivkovicmilos zivkovicmilos deleted the fix/trie-refactor branch February 2, 2022 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lazartravica lazartravica lazartravica approved these changes

@Kourin1996 Kourin1996 Kourin1996 approved these changes

@0xAleksaOpacic 0xAleksaOpacic 0xAleksaOpacic approved these changes

Assignees

@zivkovicmilos zivkovicmilos

@dbrajovic dbrajovic

Labels
hotfix Major bug fix that should be merged ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zivkovicmilos @dbrajovic @lazartravica @Kourin1996 @0xAleksaOpacic