-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JSONRPC] Fix websocket subscription #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Thank you manual testing instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for hunting down this bug 🙏
I've left some comments regarding the test that we should discuss 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fixes EDGE-387
Description
This PR fixes the issue of websocket subscriptions becoming unresponsive after a predefined timeout.
Changes include
Checklist
Testing
Manual tests
Use the
websocat
tool to verify the subscription is sending responses:websocat [node_ws_url]
websocat
):{"id": 1, "method": "eth_subscribe", "params": ["newHeads"]}