[Feature] Adding loadbot ERC20 and ERC721 token transfer mode #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new flag option for erc20 transfers * Added deployContract function * Added the option to pass parameters to smart contract constructor * Changed executeTxn method to support multiple transaction mods * Added Contract Deployment metrics to the output
* Added gasLimit metric * Added percentual gas usage metric * Increased receipt timeout * Added condition to show contract deploy metrics
Kourin1996
reviewed
Mar 1, 2022
* Remove unnessesary print line * Decrese the token transfer amount
* Moved SetContractAddress to TransactionGenerator * Moved contractAddress to BaseGenerator
* Removed/added comments * Renamed transactions.go to deploy_contract.go * Pleased linter gods
* Added max-wait flag for custom time to wait for receipts
ZeljkoBenovic
requested review from
zivkovicmilos and
lazartravica
as code owners
0xAleksaOpacic
changed the title
dbrajovic
reviewed
Mar 3, 2022
dbrajovic
approved these changes
Mar 3, 2022
zivkovicmilos
suggested changes
Mar 9, 2022
There was a problem hiding this comment.
I've left some comments that need to be addressed.
The PR looks good, but there are a few problematic parts that worry me, namely how we merged the Transaction generator and contract / token generator logic, and why we removed dynamic wait times for transactions.
Please review the comments and we can discuss 🙏
* set more detailed err output in initContractAndArgs method
* run this method only if any erc mode is set
…etrics * output contract block details only if any erc mode was selected
* added hasValidDeployParams
* added configurable receipt timeout max-wait
* moved contract metrics to dedicated struct
* deploy contract only if isTokenTransferMode is true
…ator * created new ContractTxnGenerator interface * prettyfied erc20abi json * created dedicated method for initializing blocks map * dynamicaly set txn or tokenTxn generator
Kourin1996
approved these changes
Mar 28, 2022
zivkovicmilos
approved these changes
Mar 28, 2022
* added erc20 total token supply value description * lowered value for erc20 token transfers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ERC20 and ERC721 token transactions feature to the loadbot.
It will deploy a new ERC20 or ERC721 SC to the network and make ERC20 or ERC721 token or mint transactions.
New
--mode erc20and--mode erc721switches are implemented.The loadbot output now shows gas related metrics ( gasLimit and gasUsed) and the derived block utilization.
Fixes EDGE-452
Changes include
Checklist
Testing
Manual tests
Pull branch and run the loadbot with new mode switch. For example:
go run main.go loadbot --mode erc20 --jsonrpc http://127.0.0.1:40001 --grpc-address 127.0.0.1:30001 --sender 0x228466F2C715CbEC05dEAbfAc040ce3619d7CF0B --receiver 0xca48694ebcB2548dF5030372BE4dAad694ef174e --count 50 --value 0x101 --tps 200Documentation update
Updated docs 0xPolygon/polygon-edge-docs#68
Additional comments
Before running the loadbot env vars with acc/keys need to be set:
export LOADBOT_<account address>=<account private key>