Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix failing TestBroadcast on local #461

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

Kourin1996
Copy link
Contributor

Description

This PR fixes the issue in TestBroadcast e2e test. This test uses NewTestServers to start multiple servers but used port is not marked occupied if IP address is not given for JSON-RPC address. then the following servers will use same port.

This PR sets default local IP address for test server in e2e.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@zivkovicmilos zivkovicmilos added the hotfix Major bug fix that should be merged ASAP label Mar 16, 2022
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and can confirm it works fine 💯

Thank you for going the extra mile to clean up the code a bit, it really makes a difference in the long run 🙏

@Kourin1996 Kourin1996 merged commit 06e11ea into develop Mar 16, 2022
@Kourin1996 Kourin1996 deleted the hotfix/fix-TestBroadcast branch March 16, 2022 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix Major bug fix that should be merged ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants