Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ibft switch output #478

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Fix ibft switch output #478

merged 1 commit into from
Mar 29, 2022

Conversation

0xAleksaOpacic
Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic commented Mar 29, 2022 •
edited
Loading

Description

This PR fixes ibft snapshot output.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Run go run main.go ibft snapshot --grpc-address localhost:10000 and go run main.go ibft snapshot --grpc-address localhost:10000 --json

Output should appear

@0xAleksaOpacic 0xAleksaOpacic self-assigned this Mar 29, 2022
zivkovicmilos
zivkovicmilos approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 💯

Looks great 👍

@zivkovicmilos zivkovicmilos linked an issue Mar 29, 2022 that may be closed by this pull request
ibft snapshot command not returning expected output #476
Closed
@0xAleksaOpacic 0xAleksaOpacic added the bug fix Functionality that fixes a bug label Mar 29, 2022
@0xAleksaOpacic 0xAleksaOpacic merged commit 6c8db85 into develop Mar 29, 2022
@0xAleksaOpacic 0xAleksaOpacic deleted the bugfix/ibft_snapshot_not_returning_output branch March 29, 2022 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@Kourin1996 Kourin1996 Kourin1996 approved these changes

@lazartravica lazartravica Awaiting requested review from lazartravica

Assignees

@0xAleksaOpacic 0xAleksaOpacic

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ibft snapshot command not returning expected output
3 participants
@0xAleksaOpacic @zivkovicmilos @Kourin1996