Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rolling average gas price #483

Merged
merged 4 commits into from
Apr 9, 2022
Merged

Fix rolling average gas price #483

merged 4 commits into from
Apr 9, 2022

Conversation

zivkovicmilos
Copy link
Contributor

@zivkovicmilos zivkovicmilos commented Mar 30, 2022 •
edited
Loading

Description

This PR fixes a bug with calculating the average gas price for the blockchain.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Added coverage tests for possible edge-cases.

@zivkovicmilos zivkovicmilos self-assigned this Mar 30, 2022
@zivkovicmilos zivkovicmilos changed the title Cleanup the UpdateGasPriceAvg func Fix rolling average gas price Mar 30, 2022
@zivkovicmilos zivkovicmilos linked an issue Mar 30, 2022 that may be closed by this pull request
Running an Edge network with 0 transaction fee #477
Closed
@zivkovicmilos zivkovicmilos added the bug fix Functionality that fixes a bug label Mar 31, 2022
@zivkovicmilos zivkovicmilos marked this pull request as ready for review March 31, 2022 13:06
Kourin1996
Kourin1996 suggested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@Kourin1996 Kourin1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I've left some small code improvements. Please check them

blockchain/blockchain.go Outdated Show resolved Hide resolved
blockchain/blockchain.go Show resolved Hide resolved
@zivkovicmilos zivkovicmilos merged commit 29058a5 into develop Apr 9, 2022
@zivkovicmilos zivkovicmilos deleted the fix/gas-price-average branch April 9, 2022 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kourin1996 Kourin1996 Kourin1996 approved these changes

@dbrajovic dbrajovic dbrajovic approved these changes

@lazartravica lazartravica Awaiting requested review from lazartravica

@0xAleksaOpacic 0xAleksaOpacic Awaiting requested review from 0xAleksaOpacic

@ZeljkoBenovic ZeljkoBenovic Awaiting requested review from ZeljkoBenovic

Assignees

@zivkovicmilos zivkovicmilos

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running an Edge network with 0 transaction fee
3 participants
@zivkovicmilos @Kourin1996 @dbrajovic