Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove waiting for the next block in e2e tests #485

Merged
merged 15 commits into from
May 4, 2022

Conversation

zivkovicmilos
Copy link
Contributor

Description

This PR fixes a minor testing issue, where tests would assume transactions are contained in the next block, when that doesn't have to be the case, and thus causing GH actions to sometimes fail.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@zivkovicmilos zivkovicmilos added the bug fix Functionality that fixes a bug label Apr 1, 2022
@zivkovicmilos zivkovicmilos self-assigned this Apr 1, 2022
Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for improving our test suite!

e2e/framework/testserver.go Outdated Show resolved Hide resolved
e2e/pos_test.go Outdated Show resolved Hide resolved
e2e/txpool_test.go Outdated Show resolved Hide resolved
e2e/txpool_test.go Outdated Show resolved Hide resolved
e2e/txpool_test.go Show resolved Hide resolved
e2e/txpool_test.go Show resolved Hide resolved
e2e/txpool_test.go Show resolved Hide resolved
@Kourin1996
Copy link
Contributor

@zivkovicmilos When I run tests several times locally and I always saw same error. Can you run test locally?

--- FAIL: TestPoS_UnstakeExploit (11.10s)
    pos_test.go:401: unable to wait for receipts, [unable to wait for receipt, timeout unable to wait for receipt, timeout unable to wait for receipt, timeout unable to wait for receipt, timeout]
FAIL

@zivkovicmilos
Copy link
Contributor Author

@Kourin1996

Located the problem with the gas limit in the test.

Fixed 👍

5200166

Copy link
Contributor

@Kourin1996 Kourin1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zivkovicmilos zivkovicmilos merged commit b74ffa8 into develop May 4, 2022
@zivkovicmilos zivkovicmilos deleted the fix/remove-waitforblock branch May 4, 2022 10:21
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants