[Feature] Added support for YAML/YML config file format and configurable server log output to file #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added --log-to server flag * added newLogger and setLogFileWriter func * logger instnce set to write log output to file if defined * added test to Makefile
* added support for yaml files * added example-config.yaml file with minimal config
ZeljkoBenovic
requested review from
zivkovicmilos,
lazartravica and
Kourin1996
as code owners
Kourin1996
reviewed
Apr 27, 2022
|
Confirmed it worked locally |
zivkovicmilos
approved these changes
May 5, 2022
* created new func newFileLogger and newCLILogger * renamed newLogger to newLoggerFromConfig * using params.rawConfig.LogFilePath to store flag value
* server export command exports config file with default values in yaml format * changed server command flags default values to pull from DefaultConfig() instead of hardcoded * server command now requires --data-dir flag to be set to some string value because server init requires it * removed DefaultMaxSlots const as this value is now pulled from DefaultConfig()
dbrajovic
approved these changes
May 6, 2022
* server export command moved to dedicated package * added success message to the output * added support for exporting config file to json format
ZeljkoBenovic
force-pushed
the
feature/configurable_log_output
branch
from
0f871fc
to
9350d7d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the support for starting the server with configuration file written in YAML syntax.
Added the
example-config.yamlfile with minimal configuration as a starting point.Additionally, this PR introduces a new server flag
--log-towhich provides the operator with an option to store all server output to a log file, instead of only having console logs.Added the make test option to the Makefile for easy testing.
Changes include
Checklist
Testing
Manual tests
Modify per your environment and use the
example-config.yamlfile as an argument to theserver --configflag to start the server.When starting the server set
--log-to <file_name>flag have all logs written in a file. With this flag set, the server command will not have any console outputs.Fixes EDGE-39