Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GH actions script #531

Merged
merged 8 commits into from
May 5, 2022
Merged

Update GH actions script #531

merged 8 commits into from
May 5, 2022

Conversation

zivkovicmilos
Copy link
Contributor

@zivkovicmilos zivkovicmilos commented May 2, 2022 •
edited
Loading

Description

This PR updates the GH actions script to use v3 instead of v2 for the checkout action, and removes redundant steps.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Additional Comments

Fixes EDGE-536

@zivkovicmilos zivkovicmilos added the feature New update to Polygon Edge label May 2, 2022
@zivkovicmilos zivkovicmilos self-assigned this May 2, 2022
@zivkovicmilos
Copy link
Contributor Author

zivkovicmilos commented May 2, 2022 •
edited
Loading

@ZeljkoBenovic

Is notify-deployer still relevant?

Checked internally, still relevant ✅

@zivkovicmilos zivkovicmilos marked this pull request as ready for review May 2, 2022 15:12
@zivkovicmilos zivkovicmilos changed the base branch from develop to feature/test-shaving May 4, 2022 11:13
@zivkovicmilos zivkovicmilos merged commit 36ecb01 into feature/test-shaving May 5, 2022
@zivkovicmilos zivkovicmilos deleted the feature/gh-actions branch May 5, 2022 09:06
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kourin1996 Kourin1996 Kourin1996 approved these changes

@dbrajovic dbrajovic dbrajovic approved these changes

@lazartravica lazartravica Awaiting requested review from lazartravica

@0xAleksaOpacic 0xAleksaOpacic Awaiting requested review from 0xAleksaOpacic

@ZeljkoBenovic ZeljkoBenovic Awaiting requested review from ZeljkoBenovic

Assignees

@zivkovicmilos zivkovicmilos

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zivkovicmilos @Kourin1996 @dbrajovic