-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove contractAddress from receipt if not contract deployment #546
Merged
0xAleksaOpacic
merged 8 commits into
develop
from
bugfix/native_transfers_should_not_have_contract_address
May 16, 2022
Merged
Remove contractAddress from receipt if not contract deployment #546
0xAleksaOpacic
merged 8 commits into
develop
from
bugfix/native_transfers_should_not_have_contract_address
May 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAleksaOpacic
requested review from
zivkovicmilos,
lazartravica and
Kourin1996
as code owners
May 11, 2022 10:29
0xAleksaOpacic
added
bug fix
Functionality that fixes a bug
breaking change
Functionality that contains breaking changes
labels
May 11, 2022
Kourin1996
approved these changes
May 12, 2022
zivkovicmilos
approved these changes
May 12, 2022
Kourin1996
approved these changes
May 12, 2022
@zivkovicmilos @Aleksao998 Let's plan the release accordingly with: Is the old blockchain produced by old clients still able to be synced by the new client? |
zivkovicmilos
deleted the
bugfix/native_transfers_should_not_have_contract_address
branch
May 22, 2022 10:17
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Native tx and calling contract methods should not have ContractAddress field set to 0x0 address.
FIxes EDGE-547
Changes include
Breaking changes
Yes this is breaking change and should go into minor release
Checklist
Testing
Manual tests
Sending 3 types of tx and checking receipt