Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove contractAddress from receipt if not contract deployment #546

Conversation

0xAleksaOpacic
Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic commented May 11, 2022

Description

Native tx and calling contract methods should not have ContractAddress field set to 0x0 address.
FIxes EDGE-547

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Yes this is breaking change and should go into minor release

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Sending 3 types of tx and checking receipt

  1. Native transaction
  2. Contract creation
  3. Calling contract method

@0xAleksaOpacic 0xAleksaOpacic self-assigned this May 11, 2022
@0xAleksaOpacic 0xAleksaOpacic added bug fix Functionality that fixes a bug breaking change Functionality that contains breaking changes labels May 11, 2022
@lazartravica
Copy link
Contributor

@zivkovicmilos @Aleksao998 Let's plan the release accordingly with:

Is the old blockchain produced by old clients still able to be synced by the new client?

@zivkovicmilos zivkovicmilos added this to the 0.4.0 milestone May 13, 2022
@0xAleksaOpacic 0xAleksaOpacic merged commit a86fca1 into develop May 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
@zivkovicmilos zivkovicmilos deleted the bugfix/native_transfers_should_not_have_contract_address branch May 22, 2022 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Functionality that contains breaking changes bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants