Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Multiple CLI Flags RequiredTogether or MutuallyExclusive #616

Merged
merged 9 commits into from
Jul 6, 2022
Merged

Make Multiple CLI Flags RequiredTogether or MutuallyExclusive #616

merged 9 commits into from
Jul 6, 2022

Conversation

Kourin1996
Copy link
Contributor

@Kourin1996 Kourin1996 commented Jun 30, 2022 •
edited
Loading

Fix EDGE-636

Description

This PR adds CLI flags validation using new feature of Cobra.
Mark some flags RequiredTogether or MutuallyExclusive.

In addition,

  • Remove default value description from text (Cobra displays default value)
  • Remove duplicate code setRequiredFlags

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Kourin1996 Kourin1996 self-assigned this Jun 30, 2022
@Kourin1996 Kourin1996 added the feature New update to Polygon Edge label Jun 30, 2022
@Kourin1996 Kourin1996 marked this pull request as ready for review June 30, 2022 06:46
0xAleksaOpacic
0xAleksaOpacic approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for refactor you did!

zivkovicmilos
zivkovicmilos approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

@Kourin1996 Kourin1996 merged commit e225e5b into develop Jul 6, 2022
@Kourin1996 Kourin1996 deleted the feature/required-and-exclusive-flags branch July 6, 2022 08:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@0xAleksaOpacic 0xAleksaOpacic 0xAleksaOpacic approved these changes

@lazartravica lazartravica Awaiting requested review from lazartravica

Assignees

@Kourin1996 Kourin1996

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kourin1996 @zivkovicmilos @0xAleksaOpacic