Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing tests #636

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Skip failing tests #636

merged 2 commits into from
Jul 11, 2022

Conversation

0xAleksaOpacic
Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic commented Jul 11, 2022

Description

These 2 tests failed locally
TestBroadcast is something we know it's not stable and should be fixed. I've opened the linear task
Test for syncing module will be deleted when we merge lightning sync

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #636 (404470d) into develop (ecd05ae) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #636      +/-   ##
===========================================
- Coverage    51.84%   51.63%   -0.22%     
===========================================
  Files          109      109              
  Lines        16064    16064              
===========================================
- Hits          8328     8294      -34     
- Misses        7029     7066      +37     
+ Partials       707      704       -3     
Impacted Files Coverage Δ
protocol/sync_peer.go 64.77% <0.00%> (-13.64%) ⬇️
protocol/syncer.go 61.62% <0.00%> (-6.17%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lazartravica lazartravica merged commit 7906142 into develop Jul 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2022
@lazartravica lazartravica deleted the bug/skip_failing_tests branch July 11, 2022 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants