Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove io/ioutil package due to deprecation #723

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Conversation

Kourin1996
Copy link
Contributor

@Kourin1996 Kourin1996 commented Sep 8, 2022

Description

Replace all functions in io/ioutil package to corresponding functions in os package because io/ioutil package has been marked as decrecated from Go1.16 according to Official Release Notes https://go.dev/doc/go1.16#ioutil.

There won't be any change after replacing these functions to the new functions this doc is mentioning because most of the latest implementations in io/ioutil package are just wrappers of the functions in os.

Implementation of io/ioutil at Go 1.17: https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/io/ioutil/ioutil.go

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Kourin1996 Kourin1996 added the bug fix Functionality that fixes a bug label Sep 8, 2022
@Kourin1996 Kourin1996 self-assigned this Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #723 (ae6ee05) into develop (c39d854) will decrease coverage by 0.02%.
The diff coverage is 41.66%.

@@             Coverage Diff             @@
##           develop     #723      +/-   ##
===========================================
- Coverage    52.51%   52.48%   -0.03%     
===========================================
  Files          130      130              
  Lines        17069    17069              
===========================================
- Hits          8964     8959       -5     
- Misses        7462     7466       +4     
- Partials       643      644       +1     
Impacted Files Coverage Δ
chain/chain.go 28.69% <0.00%> (ø)
chain/chain_bindata.go 32.31% <0.00%> (ø)
jsonrpc/jsonrpc.go 18.23% <0.00%> (ø)
secrets/config.go 0.00% <0.00%> (ø)
consensus/ibft/fork/helper.go 81.81% <50.00%> (ø)
secrets/local/local.go 75.70% <50.00%> (ø)
network/e2e_testing.go 63.89% <100.00%> (ø)
state/runtime/precompiled/testing.go 80.43% <100.00%> (ø)
tests/testing.go 69.33% <100.00%> (ø)
network/server_discovery.go 73.88% <0.00%> (-1.92%) ⬇️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@Kourin1996 Kourin1996 merged commit bf909f5 into develop Sep 21, 2022
@Kourin1996 Kourin1996 deleted the fix/remove-ioutil branch September 21, 2022 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants