Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github.com/libp2p/go-libp2p from to v0.22.0 and Remove github.com/libp2p/go-libp2p-core #730

Merged
merged 9 commits into from
Sep 21, 2022
Merged

Upgrade github.com/libp2p/go-libp2p from to v0.22.0 and Remove github.com/libp2p/go-libp2p-core #730

merged 9 commits into from
Sep 21, 2022

Conversation

Kourin1996
Copy link
Contributor

@Kourin1996 Kourin1996 commented Sep 12, 2022 •
edited
Loading

Fixes EDGE-850

Description

This PR contains the following auto-generated PR:
#701
#728
#729
#740

github.com/libp2p/go-libp2p-core has moved to github.com/libp2p/go-libp2p from v0.22.0 and github.com/libp2p/go-libp2p-core has been marked as deprecated. Some recent auto-generated PRs failed tests because codes in Edge contains github.com/libp2p/go-libp2p-core.

This PR upgrades the related packages at once and remove github.com/libp2p/go-libp2p-core from Edge.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

dependabot bot and others added 7 commits September 5, 2022 14:40
@dependabot
Bump github.com/libp2p/go-libp2p-pubsub from 0.7.1 to 0.8.0
8ceb80f 
Bumps [github.com/libp2p/go-libp2p-pubsub](https://github.com/libp2p/go-libp2p-pubsub) from 0.7.1 to 0.8.0.
- [Release notes](https://github.com/libp2p/go-libp2p-pubsub/releases)
- [Commits](libp2p/go-libp2p-pubsub@v0.7.1...v0.8.0)

---
updated-dependencies:
- dependency-name: github.com/libp2p/go-libp2p-pubsub
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump github.com/libp2p/go-libp2p-core from 0.17.0 to 0.20.1
bcc19c0 
Bumps [github.com/libp2p/go-libp2p-core](https://github.com/libp2p/go-libp2p-core) from 0.17.0 to 0.20.1.
- [Release notes](https://github.com/libp2p/go-libp2p-core/releases)
- [Commits](libp2p/go-libp2p-core@v0.17.0...v0.20.1)

---
updated-dependencies:
- dependency-name: github.com/libp2p/go-libp2p-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump github.com/libp2p/go-libp2p-kbucket from 0.4.7 to 0.5.0
61dde52 
Bumps [github.com/libp2p/go-libp2p-kbucket](https://github.com/libp2p/go-libp2p-kbucket) from 0.4.7 to 0.5.0.
- [Release notes](https://github.com/libp2p/go-libp2p-kbucket/releases)
- [Commits](libp2p/go-libp2p-kbucket@v0.4.7...v0.5.0)

---
updated-dependencies:
- dependency-name: github.com/libp2p/go-libp2p-kbucket
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@Kourin1996
Merge remote-tracking branch 'origin/dependabot-go_modules-develop-gi…
3eca5a5 
…thub.com-libp2p-go-libp2p-kbucket-0.5.0' into feature/upgrade-go-libp2p-to-0.22.0
@Kourin1996
Merge remote-tracking branch 'origin/dependabot-go_modules-develop-gi…
19666d6 
…thub.com-libp2p-go-libp2p-pubsub-0.8.0' into feature/upgrade-go-libp2p-to-0.22.0
@Kourin1996
Remove libp2p/golibp2p-core because of deprecation
6f4ee92
@Kourin1996
Remove github.com/libp2p/go-libp2p-core from go.mod
4d52b6e
@Kourin1996 Kourin1996 added the feature New update to Polygon Edge label Sep 12, 2022
@Kourin1996 Kourin1996 self-assigned this Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022 •
edited
Loading

Codecov Report

Merging #730 (362de64) into develop (c39d854) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #730      +/-   ##
===========================================
- Coverage    52.51%   52.48%   -0.03%     
===========================================
  Files          130      130              
  Lines        17069    17069              
===========================================
- Hits          8964     8959       -5     
- Misses        7462     7466       +4     
- Partials       643      644       +1
Impacted Files Coverage Δ
consensus/ibft/transport.go 0.00% <ø> (ø)
network/bootnodes.go 100.00% <ø> (ø)
network/connections.go 98.07% <ø> (ø)
network/dial/dial_queue.go 87.93% <ø> (ø)
network/dial/dial_task.go 0.00% <ø> (ø)
network/discovery/discovery.go 35.11% <ø> (ø)
network/e2e_testing.go 63.89% <ø> (ø)
network/gossip.go 60.37% <ø> (ø)
network/identity/identity.go 18.36% <ø> (ø)
network/keystore.go 42.30% <ø> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Kourin1996 Kourin1996 added dependencies Update to the dependencies and removed feature New update to Polygon Edge labels Sep 14, 2022
0xAleksaOpacic
0xAleksaOpacic approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed locally

@zivkovicmilos zivkovicmilos mentioned this pull request Sep 19, 2022
Closed
zivkovicmilos
zivkovicmilos approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing locally, thank you for the fix 🙏

0xAleksaOpacic
0xAleksaOpacic approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, passed locally

@Kourin1996 Kourin1996 merged commit a1fa76e into develop Sep 21, 2022
@Kourin1996 Kourin1996 deleted the feature/upgrade-go-libp2p-to-0.22.0 branch September 21, 2022 13:52
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@0xAleksaOpacic 0xAleksaOpacic 0xAleksaOpacic approved these changes

@dbrajovic dbrajovic dbrajovic approved these changes

@lazartravica lazartravica Awaiting requested review from lazartravica

Assignees

@Kourin1996 Kourin1996

Labels
dependencies Update to the dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kourin1996 @zivkovicmilos @0xAleksaOpacic @dbrajovic