Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved golangci linter config to the separate file #764

Merged

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Sep 26, 2022

Description

Moved golangci config to the single file so github actions and local setup could use the same config file. Fixed existing linter issues.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #764 (9bea3f3) into develop (29177a3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #764      +/-   ##
===========================================
+ Coverage    52.48%   52.50%   +0.01%     
===========================================
  Files          130      130              
  Lines        17069    17063       -6     
===========================================
  Hits          8959     8959              
+ Misses        7466     7460       -6     
  Partials       644      644              
Impacted Files Coverage Δ
helper/keccak/keccak.go 0.00% <ø> (ø)
helper/keccak/pool.go 0.00% <ø> (ø)
jsonrpc/eth_endpoint.go 71.49% <ø> (ø)
types/receipt.go 11.82% <ø> (+0.24%) ⬆️
state/txn.go 19.76% <100.00%> (ø)
types/buildroot/buildroot_fast.go 79.16% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will play nicely with our local IDE, nice one!

.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

I've left a couple of comments on the config file itself

Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begmaroman begmaroman merged commit e25825c into develop Sep 27, 2022
@begmaroman begmaroman deleted the feature/move-golangci-config-out-from-github-actions branch September 27, 2022 09:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants