Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Workflow Rework #765

Merged

Conversation

epikichi
Copy link
Contributor

@epikichi epikichi commented Sep 27, 2022

Description

This PR introduces a rework to our Github Actions workflows, as shown on our internal RFC. The proper Github environments needs to be set before merging for these workflows to function properly.

Major Workflow Changes

Reusable workflows

  • Pull Request CI
  • DevNet Deployment
  • TestNet Deployment
  • Loadbot Performance Testing
  • Pandora's Box Performance Testing
  • GoSec Scan

@epikichi epikichi added don't merge Please don't merge this functionality temporarily feature New update to Polygon Edge labels Sep 27, 2022
@epikichi epikichi self-assigned this Sep 27, 2022
Copy link
Contributor

@ZeljkoBenovic ZeljkoBenovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🥇
Left some minor comments.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.testnet.yml Outdated Show resolved Hide resolved
@epikichi epikichi changed the title initial workflow rework Initial Workflow Rework Sep 30, 2022
@epikichi
Copy link
Contributor Author

epikichi commented Oct 4, 2022

Expected to resolve conflicts from #776

.github/workflows/deploy.devnet.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.devnet.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

@epikichi epikichi merged commit d794a2a into develop Oct 7, 2022
@epikichi epikichi deleted the epikichi/edge-868-adopt-changes-into-0xpolygonpolygon-edge branch October 7, 2022 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2022
@epikichi epikichi removed the don't merge Please don't merge this functionality temporarily label Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants