Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding netgo build tag for Linux releases #779

Merged

Conversation

epikichi
Copy link
Contributor

@epikichi epikichi commented Oct 6, 2022

Description

Introducing this release change to provide more consistent network behaviors. A common reported behavior is chain configurations with dns multiaddr ending in .local do not resolve correctly. This change will set the release package/image to use the Go resolver.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #779 (f69848f) into develop (66897d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #779   +/-   ##
========================================
  Coverage    52.70%   52.70%           
========================================
  Files          130      130           
  Lines        17146    17146           
========================================
  Hits          9037     9037           
  Misses        7461     7461           
  Partials       648      648           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epikichi epikichi merged commit 34ec940 into develop Oct 7, 2022
@epikichi epikichi deleted the epikichi/edge-884-update-goreleaser-to-build-with-netgo branch October 7, 2022 11:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants