Fix unit test for event tracker #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
requested review from
Nemanja0x,
goran-ethernal,
igorcrevar,
b00ris and
JekaMas
Stefan-Ethernal
force-pushed
the
fix/v3-parity-linters
branch
from
134d806
to
3c60473
Compare
goran-ethernal
approved these changes
Nov 21, 2022
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #935 +/- ##
====================================================
Coverage ? 53.84%
====================================================
Files ? 163
Lines ? 21566
Branches ? 0
====================================================
Hits ? 11613
Misses ? 9007
Partials ? 946 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Nemanja0x
approved these changes
Nov 21, 2022
ferranbt
approved these changes
Nov 21, 2022
JekaMas
reviewed
Nov 21, 2022
| server.TxnTo(addr, "emitEvent") | ||
| receipt, err := server.TxnTo(addr, "emitEvent") | ||
| require.NoError(t, err) | ||
| require.True(t, receipt.Status == uint64(types.ReceiptSuccess)) |
There was a problem hiding this comment.
Does it worth it to use require.Equal ?
JekaMas
approved these changes
Nov 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix linters on
v3-paritybranch andTestEventTracker_TrackSyncEventsunit test, due to the recent changes in theethgolibrary (umbracle/ethgo#229).Changes include
Checklist
Testing