Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test for event tracker #935

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Nov 19, 2022

Description

Fix linters on v3-parity branch and TestEventTracker_TrackSyncEvents unit test, due to the recent changes in the ethgo library (umbracle/ethgo#229).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal self-assigned this Nov 19, 2022
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Nov 19, 2022
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review November 21, 2022 08:41
@Stefan-Ethernal Stefan-Ethernal changed the title V3 parity lint errors V3 parity fixes Nov 21, 2022
@Stefan-Ethernal Stefan-Ethernal changed the title V3 parity fixes Fix unit test for event tracker Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature/v3-parity@2968d5f). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             feature/v3-parity     #935   +/-   ##
====================================================
  Coverage                     ?   53.84%           
====================================================
  Files                        ?      163           
  Lines                        ?    21566           
  Branches                     ?        0           
====================================================
  Hits                         ?    11613           
  Misses                       ?     9007           
  Partials                     ?      946           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

server.TxnTo(addr, "emitEvent")
receipt, err := server.TxnTo(addr, "emitEvent")
require.NoError(t, err)
require.True(t, receipt.Status == uint64(types.ReceiptSuccess))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it worth it to use require.Equal ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stefan-Ethernal Stefan-Ethernal merged commit db63825 into feature/v3-parity Nov 21, 2022
@Stefan-Ethernal Stefan-Ethernal deleted the fix/v3-parity-linters branch November 21, 2022 09:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants