Skip to content

Commit

Permalink
rebase fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
invocamanman committed Nov 23, 2022
1 parent ebe85a6 commit c70978d
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions compiled-contracts/Bridge.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions compiled-contracts/BridgeMock.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions compiled-contracts/ProofOfEfficiency.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions compiled-contracts/ProofOfEfficiencyMock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion contracts/Bridge.sol
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ contract Bridge is
require(
timestampGlobalExitRoot != 0 &&
(block.timestamp - timestampGlobalExitRoot) >= claimTimeout,
"Bridge::_verifyLeaf: GLOBAL_EXIT_ROOT_INVALID"
"Bridge::_verifyLeaf: GLOBAL_EXIT_ROOT_INVALID_OR_NOT_YET_CLAIMABLE"
);

// Destination network must be networkID
Expand Down
2 changes: 1 addition & 1 deletion contracts/ProofOfEfficiency.sol
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ contract ProofOfEfficiency is
}

/**
* @notice Allows to stop the zk-evm if its possible to prove a different state root give the same batches.
* @notice Allows to halt the PoE if its possible to prove a different state root given the same batches
* @param initNumBatch Batch which the aggregator starts the verification
* @param finalNewBatch Last batch aggregator intends to verify
* @param newLocalExitRoot New local exit root once the batch is processed
Expand Down
2 changes: 1 addition & 1 deletion docs/ProofOfEfficiency.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ Allow the current security council to set a new security council address
uint256[2] proofC
) public
```
Allows to stop the zk-evm if its possible to prove a different state root give the same batches.
Allows to halt the PoE if its possible to prove a different state root given the same batches


#### Parameters:
Expand Down
8 changes: 4 additions & 4 deletions test/contracts/bridge.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ describe('Bridge Contract', () => {
metadata,
)).to.be.revertedWith('Bridge::_verifyLeaf: DESTINATION_NETWORK_DOES_NOT_MATCH');

// Check GLOBAL_EXIT_ROOT_INVALID assert
// Check GLOBAL_EXIT_ROOT_INVALID_OR_NOT_YET_CLAIMABLE assert
await expect(bridgeContract.claimAsset(
proof,
index,
Expand All @@ -753,7 +753,7 @@ describe('Bridge Contract', () => {
destinationAddress,
amount,
metadata,
)).to.be.revertedWith('Bridge::_verifyLeaf: GLOBAL_EXIT_ROOT_INVALID');
)).to.be.revertedWith('Bridge::_verifyLeaf: GLOBAL_EXIT_ROOT_INVALID_OR_NOT_YET_CLAIMABLE');

// Check SMT_INVALID assert
await expect(bridgeContract.claimAsset(
Expand Down Expand Up @@ -1228,7 +1228,7 @@ describe('Bridge Contract', () => {
destinationAddress,
amount,
metadata,
)).to.be.revertedWith('Bridge::_verifyLeaf: GLOBAL_EXIT_ROOT_INVALID');
)).to.be.revertedWith('Bridge::_verifyLeaf: GLOBAL_EXIT_ROOT_INVALID_OR_NOT_YET_CLAIMABLE');

// Can't claim because claim timeout does not expired yet ( edge case)
await ethers.provider.send('evm_setNextBlockTimestamp', [(globalExitRootTimestamp.toNumber() + newClaimTimeout) - 1]);
Expand All @@ -1243,7 +1243,7 @@ describe('Bridge Contract', () => {
destinationAddress,
amount,
metadata,
)).to.be.revertedWith('Bridge::_verifyLeaf: GLOBAL_EXIT_ROOT_INVALID');
)).to.be.revertedWith('Bridge::_verifyLeaf: GLOBAL_EXIT_ROOT_INVALID_OR_NOT_YET_CLAIMABLE');

// Now can claim!
await expect(bridgeContract.claimAsset(
Expand Down

0 comments on commit c70978d

Please sign in to comment.