Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable initializer=false #335

Merged
merged 1 commit into from
Sep 23, 2024
Merged

disable initializer=false #335

merged 1 commit into from
Sep 23, 2024

Conversation

krlosMata
Copy link
Contributor

This PR does the following:

  • removes initializer: false in deployment scripts to call initialize() function automatically in polygonZkEVMGlobalExitRoot SC

@cla-bot cla-bot bot added the cla-signed label Sep 23, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

praetoriansentry
praetoriansentry approved these changes Sep 23, 2024
View reviewed changes
Copy link

@praetoriansentry praetoriansentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked well for me!

@invocamanman invocamanman merged commit f1839aa into develop Sep 23, 2024
6 checks passed
@leovct leovct mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praetoriansentry praetoriansentry praetoriansentry approved these changes

@invocamanman invocamanman invocamanman approved these changes

@ignasirv ignasirv Awaiting requested review from ignasirv

@laisolizq laisolizq Awaiting requested review from laisolizq

@joanestebanr joanestebanr Awaiting requested review from joanestebanr

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlosMata @praetoriansentry @invocamanman