Feature/update upgrade script #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
invocamanman
commented
Jan 3, 2023
invocamanman
commented
- Upgrade script hackmd updated
invocamanman
force-pushed
the
feature/updateUpgradeScript
branch
from
94ad2f1
to
8cf823e
Compare
invocamanman
force-pushed
the
feature/updateUpgradeScript
branch
from
8cf823e
to
afc55f3
Compare
krlosMata
requested changes
Jan 3, 2023
deployment/README.md
Outdated
|
|
||
| ## Notes | ||
|
|
||
| - `gensis.json` has been generated using the tool: `https://github.com/0xPolygonHermez/zkevm-commonjs/blob/main/tools/fill-genesis/create-genesis.js` using as generator file: `genesis-gen.json` | ||
| - `gensis.json` has been generated using the tool: `src/create-genesis.js` using as generator file: `genesis-gen.json` |
There was a problem hiding this comment.
Suggested change
| - `gensis.json` has been generated using the tool: `src/create-genesis.js` using as generator file: `genesis-gen.json` | |
| - `genesis.json` has been generated using the tool: `src/create-genesis.js` using as generator file: `genesis-gen.json` |
upgrade/README.md
Outdated
| - Update the `polygonZkEVMFactory` with the new implementation contract you want to upgrade | ||
| - Run the script | ||
|
|
||
| Otherwise, inc ase of timelock use `timeLockUpgrade.js` |
There was a problem hiding this comment.
Suggested change
| Otherwise, inc ase of timelock use `timeLockUpgrade.js` | |
| Otherwise, in case of timelock use `timeLockUpgrade.js` |
upgrade/README.md
Outdated
| - Update the `minDelay` with the delay that you want to use | ||
| - Run the script | ||
| - Now the necessary transactions to interact with the timelock are printed in the screen `schedule` and `execute` | ||
| - With the owner of the timelock ( multisig or account), send the data printed by `schedule` to the `Timelock` contract. |
There was a problem hiding this comment.
Suggested change
| - With the owner of the timelock ( multisig or account), send the data printed by `schedule` to the `Timelock` contract. | |
| - With the owner of the timelock (multisig or account), send the data printed by `schedule` to the `Timelock` contract. |
upgrade/README.md
Outdated
| - Run the script | ||
| - Now the necessary transactions to interact with the timelock are printed in the screen `schedule` and `execute` | ||
| - With the owner of the timelock ( multisig or account), send the data printed by `schedule` to the `Timelock` contract. | ||
| - Once the necessary timeout has pass, with the same account you can now send the data printed by `execute` to the `Timelock` contract and the contracts will be upgraded. |
There was a problem hiding this comment.
Suggested change
| - Once the necessary timeout has pass, with the same account you can now send the data printed by `execute` to the `Timelock` contract and the contracts will be upgraded. | |
| - Once the necessary timeout has expired, with the same account you can now send the data printed by `execute` to the `Timelock` contract and the contracts will be upgraded. |
upgrade/simpleUpgradeScript.js
Outdated
| @@ -27,24 +27,15 @@ async function main() { | |||
| // compìle contracts | |||
| await hre.run('compile'); | |||
|
|
|||
| const polygonZkEVMProxyAddress = '0xfefefefefefefefefefefefee'; | |||
| const polygonZkEVMFactory = await ethers.getContractFactory('PolygonZkEVMMock'); | |||
| const proxyPolygonAddress = '0xfefefefefefefefefefefefee'; | |||
There was a problem hiding this comment.
This parameter should be loaded by cli or input-upgrade.json
| @@ -27,23 +27,26 @@ async function main() { | |||
| // compìle contracts | |||
There was a problem hiding this comment.
Output with upgrade information should be provided as well in json format
krlosMata
requested changes
Jan 9, 2023
upgrade/timeLockUpgrade.js
Outdated
| minDelay, | ||
| ], | ||
| ); | ||
| // Executre operation |
There was a problem hiding this comment.
Suggested change
| // Executre operation | |
| // Execute operation |
| const output = []; | ||
|
|
||
| // Upgrade zkevm | ||
| for (const upgrade of upgradeParameters.upgrades) { |
There was a problem hiding this comment.
I would check in advance upgrade.contractName existence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.