Feature/spear bits audit3 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invocamanman
force-pushed
the
feature/spearBitsAudit3
branch
from
7362d3f
to
0e86264
Compare
invocamanman
force-pushed
the
feature/spearBitsAudit3
branch
from
9a193f3
to
04e5072
Compare
invocamanman
force-pushed
the
feature/spearBitsAudit3
branch
from
04e5072
to
744ac34
Compare
krlosMata
requested changes
Jan 25, 2023
| @@ -153,6 +155,9 @@ contract PolygonZkEVMBridge is | |||
| // Ether is treated as ether from mainnet | |||
| originNetwork = MAINNET_NETWORK_ID; | |||
| } else { | |||
| // Check msg.value is 0 if tokens are bridged | |||
| require(msg.value == 0, "PolygonZkEVMBridge::bridgeAsset: Expected zero native asset value when bridging ERC20 tokens"); | |||
There was a problem hiding this comment.
What if there is an ERC20 token that requires some msg.value in order to perform its safeTransferFrom custom implementation?
There was a problem hiding this comment.
This is not contemplated, and if it was the case we should send the msg.value along with the transferFrom function, which i think usually is not payable
There was a problem hiding this comment.
This avoids bad usage of the Bridge but I think it is not required xD
invocamanman
force-pushed
the
feature/spearBitsAudit3
branch
from
5ee8e99
to
745f589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the following issues:
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/18#issuecomment-1403372039
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/14
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/16
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/17
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/18
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/20
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/21
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/25
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/26
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/30
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/31
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/33
https://github.com/spearbit-audits/review-polygon-zkevm-contracts/issues/36