Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3265 accept empty closed batches from trusted #3270

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Feb 14, 2024

Closes #3265

If synchronizer receive a empty closed batch (0 bytes) from trustedNode must be store without checking anything

It could be configure in the node config file:

[Synchronizer]
(...)
	[Synchronizer.L2Synchronization]
		AcceptEmptyClosedBatches = false

What does this PR do?

Main reviewers:

Codeowner reviewers:

  • @-Alice
  • @-Bob

agnusmor and others added 30 commits January 27, 2024 19:43
* Sync old network compatibility

* logs
* removed reorgPool call
* add test for l1 sequenced batches
* removed panic after halt call as PR comments ask for
* fix rom error

* linter

* fix
…lockTimestampMargin seconds behind "now" (#3181)

* add sanity check L1BlockTimestampMargin vs now

* Update prover image to v4.0.4
* fix cache update and sync from Trusted of closed batch
…quential by default (#3191)

* fix getting URL from contract in compatibility mode
* synchronizer configuration  by default use `sequential` mode
* fix isSynced

* fix linter

* fix logs

* halt on sanity check error
* allow rpc to access the ForkID directly from DB

* update docs
* allow rpc to access the ForkID directly from DB

* update docs

* fix migration down; check for greater forkIDs instead of the next +1 (#3182)

* fix state storage config initialization

* add tests and fix get forkID by block number

* fix test TestGetForkIDByBlockNumber

---------

Co-authored-by: agnusmor <agnusmor@gmail.com>
* L1InfooTree cache is calculated when needed and is discard when a reorg happens
* synchronizer avoid panic if process trusted batch fails
* set l2 block gas limit to 2**50 (1125899906842624)

* limit L2 block gasLimit in StoreL2Block function
joanestebanr and others added 7 commits February 8, 2024 13:42
…ne. Do fatal for some finalizer halt events. Several fixes. Optmize purge pool (#3241)

* sequence batch only when sanity check is done. Do fatal for some halt events. Several fixes

* feat: optimize purge txn pool query (#3137)

* feat: optimize purge txn pool query

* fix: add new method to state interface

* feat: generate new state mocks

* fix merge

* fix %w

---------

Co-authored-by: Idris Hanafi <ifh101@gmail.com>
@joanestebanr joanestebanr added this to the v0.5.11 milestone Feb 14, 2024
@joanestebanr joanestebanr self-assigned this Feb 14, 2024
@cla-bot cla-bot bot added the cla-signed label Feb 14, 2024
@joanestebanr joanestebanr changed the base branch from develop to release/v0.5.11 February 14, 2024 08:40
@joanestebanr joanestebanr modified the milestones: v0.5.11, v0.6.0, v0.7.0 Feb 15, 2024
@joanestebanr joanestebanr changed the base branch from release/v0.5.11 to develop February 26, 2024 11:06
@joanestebanr
Copy link
Contributor Author

This PR was closed because have many not desired changes of release/v0.5.11.
Have created another one: #3370 with just the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants