-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3265 accept empty closed batches from trusted #3270
Closed
joanestebanr
wants to merge
43
commits into
develop
from
feature/3265-accept_empty_closed_batches_from_trusted
Closed
Feature/3265 accept empty closed batches from trusted #3270
joanestebanr
wants to merge
43
commits into
develop
from
feature/3265-accept_empty_closed_batches_from_trusted
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3163) * note to restart zkevm-rpc * update comment
* Sync old network compatibility * logs
* fix rom error * linter * fix
* new geth version v1.13.11
…lockTimestampMargin seconds behind "now" (#3181) * add sanity check L1BlockTimestampMargin vs now * Update prover image to v4.0.4
* fix cache update and sync from Trusted of closed batch
…quential by default (#3191) * fix getting URL from contract in compatibility mode * synchronizer configuration by default use `sequential` mode
* fix isSynced * fix linter * fix logs * halt on sanity check error
* allow rpc to access the ForkID directly from DB * update docs
* allow rpc to access the ForkID directly from DB * update docs * fix migration down; check for greater forkIDs instead of the next +1 (#3182) * fix state storage config initialization * add tests and fix get forkID by block number * fix test TestGetForkIDByBlockNumber --------- Co-authored-by: agnusmor <agnusmor@gmail.com>
* L1InfooTree cache is calculated when needed and is discard when a reorg happens
* synchronizer avoid panic if process trusted batch fails
… (it will use default "sequential" value) (#3210)
* set l2 block gas limit to 2**50 (1125899906842624) * limit L2 block gasLimit in StoreL2Block function
…ne. Do fatal for some finalizer halt events. Several fixes. Optmize purge pool (#3241) * sequence batch only when sanity check is done. Do fatal for some halt events. Several fixes * feat: optimize purge txn pool query (#3137) * feat: optimize purge txn pool query * fix: add new method to state interface * feat: generate new state mocks * fix merge * fix %w --------- Co-authored-by: Idris Hanafi <ifh101@gmail.com>
…de must be store without checking anything
joanestebanr
requested review from
tclemos,
ARR552,
ToniRamirezM,
dpunish3r and
agnusmor
as code owners
February 14, 2024 08:38
This PR was closed because have many not desired changes of release/v0.5.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3265
If synchronizer receive a empty closed batch (0 bytes) from trustedNode must be store without checking anything
It could be configure in the node config file:
What does this PR do?
Main reviewers:
Codeowner reviewers: