-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement receipts and logs #1097
Implement receipts and logs #1097
Conversation
13e86df
to
255d7f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Just need to update some of the tests because of #1172.
255d7f2
to
87d4080
Compare
Since the MemoryCTL fix was merged, we need to add BlockMetadata to the |
acb03c7
to
5506bf7
Compare
I don't understand the point of the last commit. The metadata are arrays, and as such should be serialized as arrays instead of vectors (cleaner and cheaper, we don't store the extra |
On the main branch, everything is read and written as vecs, the arrays come from a rebasing mistake I made. |
5506bf7
to
f9509af
Compare
Sorry about that, my mistake, they were supposed to be changed to arrays! |
Co-authored-by: Hamy Ratoanina <hamy.ratoanina@toposware.com> Co-authored-by: Linda Guiga <lindaguiga3@gmail.com>
b7043bd
to
6a2e242
Compare
This PR implements receipts and logs:
Most changes are additive, though
process_normalized_txn
(and internal functions) now returnsuccess
andleftover_gas
.