Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some documentation in EVM crate #1295

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

Nashtare
Copy link
Collaborator

@pgebheim That's the branch we started adding documentation on.
We didn't touch the kernel at all, nor the specs pdf (apart from adding an empty section for the new table).

Co-authored-by: Linda Guiga <linda.guiga@toposware.com>
@pgebheim
Copy link
Collaborator

@Nashtare @LindaGuiga Would you be okay with merging this as is and then adding more docs?

@Nashtare
Copy link
Collaborator Author

Sure, let me just rebase first.

@Nashtare
Copy link
Collaborator Author

@pgebheim should be ready for merging if you want!

@Nashtare Nashtare marked this pull request as ready for review October 22, 2023 19:16
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to use the "[SomeItemInScope]"-syntax to leverage rustdoc auto-linking feature. So rather than

/// Something something returns `CrossTableLookups`.

…you'd write

/// Something something returns [`CrossTableLookups`].

@Nashtare
Copy link
Collaborator Author

@dvdplm Agreed, though apart from the serialization module inside plonky2 crate, this is never used, and the plonky2_evm crate hasn't been published on crates.io, so I'd rather go for a dedicated PR updating all references with that suggestion (not just on plonky2_evm). Does that make sense to you?
cc @pgebheim

@Nashtare Nashtare added the documentation Improvements or additions to documentation label Oct 23, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Nashtare Nashtare merged commit 0d97b93 into 0xPolygonZero:main Oct 30, 2023
4 checks passed
@Nashtare Nashtare deleted the documentation branch October 30, 2023 18:28
wborgeaud added a commit that referenced this pull request Nov 3, 2023
* Add SMT types

* Progress

* Progress

* Working smt hashing

* Minor

* Fix hash

* Working insert

* Minor

* Add insert test for storage trie

* Add missing constraints for DUP/SWAP (#1310)

* Refactor wcopy syscalls

* Refactor memcpy

* Working test_simple_transfer

* Modify add11_yml.rs

* Refactor codecopy

* Fix

* Fix calldatacopy

* Fix test on interpreter side

* Remove new_stack_top_channel from StackBehavior (#1296)

* Working add11_yml.rs

* All tests compile

* Working test_balance

* Minor

* Working test_extcodesize

* All non-ignored tests pass

* Fix test_empty_txn_list

* Clippy

* smt_utils point to github

* Comments

* Fix kexit_info in test

* Review

* Update Cargo.toml

* Move empty check inside final iteration

* Remerge context flags (#1292)

* Remerge context flags

* Apply comments and revert some unwanted changes

* Merge NOT and POP flags. (#1257)

* Merge NOT and POP flags

* Add comments

* Disable remaining memory channels for POP

* Apply comments

* Fix stack

* More of memcpy_bytes

* Add some documentation in EVM crate (#1295)

Co-authored-by: Linda Guiga <linda.guiga@toposware.com>

* Combine PUSH0 and PC flags. (#1256)

* PR feedback

* Add context constraints (#1260)

* Combine JUMPDEST and KECCAK_GENERAL flags. (#1259)

* Combine JUMPDEST and KECCAK_GENERAL flags.

* Apply comments

* Fix merging of jumpdest and keccak_general.

* Add test for selfdestruct (#1321)

* Add test for selfdestruct

* Comment

* Fix test

---------

Co-authored-by: Hamy Ratoanina <hamy.ratoanina@toposware.com>
Co-authored-by: Robin Salen <salenrobin@gmail.com>
Co-authored-by: Linda Guiga <101227802+LindaGuiga@users.noreply.github.com>
Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
Co-authored-by: Linda Guiga <linda.guiga@toposware.com>
Co-authored-by: Linda Guiga <lindaguiga3@gmail.com>
pgebheim added a commit that referenced this pull request Nov 3, 2023
commit 4f854e6
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Nov 3 13:48:23 2023 +0100

    Minor

commit fbd4c78
Merge: ad580c2 c70a785
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Nov 3 13:42:45 2023 +0100

    Merge branch 'feat/type2' into type2/smt_deletion

    # Conflicts:
    #	evm/src/cpu/kernel/aggregator.rs
    #	evm/src/cpu/kernel/asm/mpt/storage/storage_write.asm
    #	evm/src/cpu/kernel/asm/smt/insert.asm
    #	evm/src/cpu/kernel/asm/smt/utils.asm
    #	evm/src/cpu/kernel/constants/mod.rs
    #	evm/src/cpu/kernel/tests/smt/mod.rs
    #	evm/tests/selfdestruct.rs

commit c70a785
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Nov 3 13:37:19 2023 +0100

    Start of SMT implementation for Type 2 zkEVM (#1315)

    * Add SMT types

    * Progress

    * Progress

    * Working smt hashing

    * Minor

    * Fix hash

    * Working insert

    * Minor

    * Add insert test for storage trie

    * Add missing constraints for DUP/SWAP (#1310)

    * Refactor wcopy syscalls

    * Refactor memcpy

    * Working test_simple_transfer

    * Modify add11_yml.rs

    * Refactor codecopy

    * Fix

    * Fix calldatacopy

    * Fix test on interpreter side

    * Remove new_stack_top_channel from StackBehavior (#1296)

    * Working add11_yml.rs

    * All tests compile

    * Working test_balance

    * Minor

    * Working test_extcodesize

    * All non-ignored tests pass

    * Fix test_empty_txn_list

    * Clippy

    * smt_utils point to github

    * Comments

    * Fix kexit_info in test

    * Review

    * Update Cargo.toml

    * Move empty check inside final iteration

    * Remerge context flags (#1292)

    * Remerge context flags

    * Apply comments and revert some unwanted changes

    * Merge NOT and POP flags. (#1257)

    * Merge NOT and POP flags

    * Add comments

    * Disable remaining memory channels for POP

    * Apply comments

    * Fix stack

    * More of memcpy_bytes

    * Add some documentation in EVM crate (#1295)

    Co-authored-by: Linda Guiga <linda.guiga@toposware.com>

    * Combine PUSH0 and PC flags. (#1256)

    * PR feedback

    * Add context constraints (#1260)

    * Combine JUMPDEST and KECCAK_GENERAL flags. (#1259)

    * Combine JUMPDEST and KECCAK_GENERAL flags.

    * Apply comments

    * Fix merging of jumpdest and keccak_general.

    * Add test for selfdestruct (#1321)

    * Add test for selfdestruct

    * Comment

    * Fix test

    ---------

    Co-authored-by: Hamy Ratoanina <hamy.ratoanina@toposware.com>
    Co-authored-by: Robin Salen <salenrobin@gmail.com>
    Co-authored-by: Linda Guiga <101227802+LindaGuiga@users.noreply.github.com>
    Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
    Co-authored-by: Linda Guiga <linda.guiga@toposware.com>
    Co-authored-by: Linda Guiga <lindaguiga3@gmail.com>

commit ad580c2
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 08:40:46 2023 +0100

    Clippy

commit fe5b8fd
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 08:39:26 2023 +0100

    s/mpt/smt in a bunch of places

commit 73dc262
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 08:15:56 2023 +0100

    Selfdestruct test passes

commit 539190f
Merge: e110941 f71f227
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 07:58:15 2023 +0100

    Merge branch 'main' into type2/smt_deletion

commit e110941
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Nov 1 17:04:38 2023 +0100

    Minor

commit f7fba35
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Nov 1 12:24:13 2023 +0100

    PR feedback

commit e528b89
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Mon Oct 30 09:11:25 2023 +0100

    Update Cargo.toml

commit 5eaf83e
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 12:34:52 2023 +0200

    Comments

commit ae9c443
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 11:51:16 2023 +0200

    smt_utils point to github

commit b3d61b7
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 11:49:33 2023 +0200

    Clippy

commit ccb3d7e
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 10:00:20 2023 +0200

    Fix test_empty_txn_list

commit 986b010
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:48:14 2023 +0200

    All non-ignored tests pass

commit 7bb0c02
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:44:40 2023 +0200

    Working test_extcodesize

commit b8a85d4
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:38:08 2023 +0200

    Minor

commit 2c01b05
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:37:05 2023 +0200

    Working test_balance

commit e370b62
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:13:36 2023 +0200

    All tests compile

commit f21bc5c
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 08:31:04 2023 +0200

    Working add11_yml.rs

commit 4e2b3f3
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 18:50:32 2023 +0200

    Modify add11_yml.rs

commit c324412
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 18:28:21 2023 +0200

    Working test_simple_transfer

commit df55e45
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 08:54:24 2023 +0200

    Add insert test for storage trie

commit ca0102f
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 08:42:03 2023 +0200

    Minor

commit dc27351
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 08:40:57 2023 +0200

    Working insert

commit f6c4067
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 25 08:07:31 2023 +0200

    Fix hash

commit c6e85eb
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 18:46:32 2023 +0200

    Minor

commit d95c430
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 18:32:05 2023 +0200

    Working smt hashing

commit fd09915
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 14:32:38 2023 +0200

    Progress

commit a706cda
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 07:37:26 2023 +0200

    Progress

commit 95e5cc1
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 13 09:19:45 2023 +0200

    Add SMT types
LindaGuiga added a commit to topos-protocol/plonky2 that referenced this pull request Nov 3, 2023
* Add SMT types

* Progress

* Progress

* Working smt hashing

* Minor

* Fix hash

* Working insert

* Minor

* Add insert test for storage trie

* Add missing constraints for DUP/SWAP (0xPolygonZero#1310)

* Refactor wcopy syscalls

* Refactor memcpy

* Working test_simple_transfer

* Modify add11_yml.rs

* Refactor codecopy

* Fix

* Fix calldatacopy

* Fix test on interpreter side

* Remove new_stack_top_channel from StackBehavior (0xPolygonZero#1296)

* Working add11_yml.rs

* All tests compile

* Working test_balance

* Minor

* Working test_extcodesize

* All non-ignored tests pass

* Fix test_empty_txn_list

* Clippy

* smt_utils point to github

* Comments

* Fix kexit_info in test

* Review

* Update Cargo.toml

* Move empty check inside final iteration

* Remerge context flags (0xPolygonZero#1292)

* Remerge context flags

* Apply comments and revert some unwanted changes

* Merge NOT and POP flags. (0xPolygonZero#1257)

* Merge NOT and POP flags

* Add comments

* Disable remaining memory channels for POP

* Apply comments

* Fix stack

* More of memcpy_bytes

* Add some documentation in EVM crate (0xPolygonZero#1295)

Co-authored-by: Linda Guiga <linda.guiga@toposware.com>

* Combine PUSH0 and PC flags. (0xPolygonZero#1256)

* PR feedback

* Add context constraints (0xPolygonZero#1260)

* Combine JUMPDEST and KECCAK_GENERAL flags. (0xPolygonZero#1259)

* Combine JUMPDEST and KECCAK_GENERAL flags.

* Apply comments

* Fix merging of jumpdest and keccak_general.

* Add test for selfdestruct (0xPolygonZero#1321)

* Add test for selfdestruct

* Comment

* Fix test

---------

Co-authored-by: Hamy Ratoanina <hamy.ratoanina@toposware.com>
Co-authored-by: Robin Salen <salenrobin@gmail.com>
Co-authored-by: Linda Guiga <101227802+LindaGuiga@users.noreply.github.com>
Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
Co-authored-by: Linda Guiga <linda.guiga@toposware.com>
Co-authored-by: Linda Guiga <lindaguiga3@gmail.com>
wborgeaud added a commit that referenced this pull request Nov 14, 2023
commit 4f854e6
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Nov 3 13:48:23 2023 +0100

    Minor

commit fbd4c78
Merge: ad580c2 c70a785
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Nov 3 13:42:45 2023 +0100

    Merge branch 'feat/type2' into type2/smt_deletion

    # Conflicts:
    #	evm/src/cpu/kernel/aggregator.rs
    #	evm/src/cpu/kernel/asm/mpt/storage/storage_write.asm
    #	evm/src/cpu/kernel/asm/smt/insert.asm
    #	evm/src/cpu/kernel/asm/smt/utils.asm
    #	evm/src/cpu/kernel/constants/mod.rs
    #	evm/src/cpu/kernel/tests/smt/mod.rs
    #	evm/tests/selfdestruct.rs

commit c70a785
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Nov 3 13:37:19 2023 +0100

    Start of SMT implementation for Type 2 zkEVM (#1315)

    * Add SMT types

    * Progress

    * Progress

    * Working smt hashing

    * Minor

    * Fix hash

    * Working insert

    * Minor

    * Add insert test for storage trie

    * Add missing constraints for DUP/SWAP (#1310)

    * Refactor wcopy syscalls

    * Refactor memcpy

    * Working test_simple_transfer

    * Modify add11_yml.rs

    * Refactor codecopy

    * Fix

    * Fix calldatacopy

    * Fix test on interpreter side

    * Remove new_stack_top_channel from StackBehavior (#1296)

    * Working add11_yml.rs

    * All tests compile

    * Working test_balance

    * Minor

    * Working test_extcodesize

    * All non-ignored tests pass

    * Fix test_empty_txn_list

    * Clippy

    * smt_utils point to github

    * Comments

    * Fix kexit_info in test

    * Review

    * Update Cargo.toml

    * Move empty check inside final iteration

    * Remerge context flags (#1292)

    * Remerge context flags

    * Apply comments and revert some unwanted changes

    * Merge NOT and POP flags. (#1257)

    * Merge NOT and POP flags

    * Add comments

    * Disable remaining memory channels for POP

    * Apply comments

    * Fix stack

    * More of memcpy_bytes

    * Add some documentation in EVM crate (#1295)

    Co-authored-by: Linda Guiga <linda.guiga@toposware.com>

    * Combine PUSH0 and PC flags. (#1256)

    * PR feedback

    * Add context constraints (#1260)

    * Combine JUMPDEST and KECCAK_GENERAL flags. (#1259)

    * Combine JUMPDEST and KECCAK_GENERAL flags.

    * Apply comments

    * Fix merging of jumpdest and keccak_general.

    * Add test for selfdestruct (#1321)

    * Add test for selfdestruct

    * Comment

    * Fix test

    ---------

    Co-authored-by: Hamy Ratoanina <hamy.ratoanina@toposware.com>
    Co-authored-by: Robin Salen <salenrobin@gmail.com>
    Co-authored-by: Linda Guiga <101227802+LindaGuiga@users.noreply.github.com>
    Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
    Co-authored-by: Linda Guiga <linda.guiga@toposware.com>
    Co-authored-by: Linda Guiga <lindaguiga3@gmail.com>

commit ad580c2
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 08:40:46 2023 +0100

    Clippy

commit fe5b8fd
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 08:39:26 2023 +0100

    s/mpt/smt in a bunch of places

commit 73dc262
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 08:15:56 2023 +0100

    Selfdestruct test passes

commit 539190f
Merge: e110941 f71f227
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 07:58:15 2023 +0100

    Merge branch 'main' into type2/smt_deletion

commit e110941
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Nov 1 17:04:38 2023 +0100

    Minor

commit f7fba35
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Nov 1 12:24:13 2023 +0100

    PR feedback

commit e528b89
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Mon Oct 30 09:11:25 2023 +0100

    Update Cargo.toml

commit 5eaf83e
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 12:34:52 2023 +0200

    Comments

commit ae9c443
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 11:51:16 2023 +0200

    smt_utils point to github

commit b3d61b7
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 11:49:33 2023 +0200

    Clippy

commit ccb3d7e
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 10:00:20 2023 +0200

    Fix test_empty_txn_list

commit 986b010
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:48:14 2023 +0200

    All non-ignored tests pass

commit 7bb0c02
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:44:40 2023 +0200

    Working test_extcodesize

commit b8a85d4
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:38:08 2023 +0200

    Minor

commit 2c01b05
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:37:05 2023 +0200

    Working test_balance

commit e370b62
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:13:36 2023 +0200

    All tests compile

commit f21bc5c
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 08:31:04 2023 +0200

    Working add11_yml.rs

commit 4e2b3f3
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 18:50:32 2023 +0200

    Modify add11_yml.rs

commit c324412
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 18:28:21 2023 +0200

    Working test_simple_transfer

commit df55e45
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 08:54:24 2023 +0200

    Add insert test for storage trie

commit ca0102f
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 08:42:03 2023 +0200

    Minor

commit dc27351
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 08:40:57 2023 +0200

    Working insert

commit f6c4067
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 25 08:07:31 2023 +0200

    Fix hash

commit c6e85eb
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 18:46:32 2023 +0200

    Minor

commit d95c430
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 18:32:05 2023 +0200

    Working smt hashing

commit fd09915
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 14:32:38 2023 +0200

    Progress

commit a706cda
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 07:37:26 2023 +0200

    Progress

commit 95e5cc1
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 13 09:19:45 2023 +0200

    Add SMT types

Co-authored-by: Paul Gebheim <pgebheim@gmail.com>
pgebheim added a commit that referenced this pull request Nov 27, 2023
* Squashed commit of the following:

commit 4f854e6
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Nov 3 13:48:23 2023 +0100

    Minor

commit fbd4c78
Merge: ad580c2 c70a785
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Nov 3 13:42:45 2023 +0100

    Merge branch 'feat/type2' into type2/smt_deletion

    # Conflicts:
    #	evm/src/cpu/kernel/aggregator.rs
    #	evm/src/cpu/kernel/asm/mpt/storage/storage_write.asm
    #	evm/src/cpu/kernel/asm/smt/insert.asm
    #	evm/src/cpu/kernel/asm/smt/utils.asm
    #	evm/src/cpu/kernel/constants/mod.rs
    #	evm/src/cpu/kernel/tests/smt/mod.rs
    #	evm/tests/selfdestruct.rs

commit c70a785
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Nov 3 13:37:19 2023 +0100

    Start of SMT implementation for Type 2 zkEVM (#1315)

    * Add SMT types

    * Progress

    * Progress

    * Working smt hashing

    * Minor

    * Fix hash

    * Working insert

    * Minor

    * Add insert test for storage trie

    * Add missing constraints for DUP/SWAP (#1310)

    * Refactor wcopy syscalls

    * Refactor memcpy

    * Working test_simple_transfer

    * Modify add11_yml.rs

    * Refactor codecopy

    * Fix

    * Fix calldatacopy

    * Fix test on interpreter side

    * Remove new_stack_top_channel from StackBehavior (#1296)

    * Working add11_yml.rs

    * All tests compile

    * Working test_balance

    * Minor

    * Working test_extcodesize

    * All non-ignored tests pass

    * Fix test_empty_txn_list

    * Clippy

    * smt_utils point to github

    * Comments

    * Fix kexit_info in test

    * Review

    * Update Cargo.toml

    * Move empty check inside final iteration

    * Remerge context flags (#1292)

    * Remerge context flags

    * Apply comments and revert some unwanted changes

    * Merge NOT and POP flags. (#1257)

    * Merge NOT and POP flags

    * Add comments

    * Disable remaining memory channels for POP

    * Apply comments

    * Fix stack

    * More of memcpy_bytes

    * Add some documentation in EVM crate (#1295)

    Co-authored-by: Linda Guiga <linda.guiga@toposware.com>

    * Combine PUSH0 and PC flags. (#1256)

    * PR feedback

    * Add context constraints (#1260)

    * Combine JUMPDEST and KECCAK_GENERAL flags. (#1259)

    * Combine JUMPDEST and KECCAK_GENERAL flags.

    * Apply comments

    * Fix merging of jumpdest and keccak_general.

    * Add test for selfdestruct (#1321)

    * Add test for selfdestruct

    * Comment

    * Fix test

    ---------

    Co-authored-by: Hamy Ratoanina <hamy.ratoanina@toposware.com>
    Co-authored-by: Robin Salen <salenrobin@gmail.com>
    Co-authored-by: Linda Guiga <101227802+LindaGuiga@users.noreply.github.com>
    Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
    Co-authored-by: Linda Guiga <linda.guiga@toposware.com>
    Co-authored-by: Linda Guiga <lindaguiga3@gmail.com>

commit ad580c2
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 08:40:46 2023 +0100

    Clippy

commit fe5b8fd
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 08:39:26 2023 +0100

    s/mpt/smt in a bunch of places

commit 73dc262
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 08:15:56 2023 +0100

    Selfdestruct test passes

commit 539190f
Merge: e110941 f71f227
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Nov 2 07:58:15 2023 +0100

    Merge branch 'main' into type2/smt_deletion

commit e110941
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Nov 1 17:04:38 2023 +0100

    Minor

commit f7fba35
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Nov 1 12:24:13 2023 +0100

    PR feedback

commit e528b89
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Mon Oct 30 09:11:25 2023 +0100

    Update Cargo.toml

commit 5eaf83e
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 12:34:52 2023 +0200

    Comments

commit ae9c443
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 11:51:16 2023 +0200

    smt_utils point to github

commit b3d61b7
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 11:49:33 2023 +0200

    Clippy

commit ccb3d7e
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 10:00:20 2023 +0200

    Fix test_empty_txn_list

commit 986b010
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:48:14 2023 +0200

    All non-ignored tests pass

commit 7bb0c02
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:44:40 2023 +0200

    Working test_extcodesize

commit b8a85d4
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:38:08 2023 +0200

    Minor

commit 2c01b05
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:37:05 2023 +0200

    Working test_balance

commit e370b62
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 09:13:36 2023 +0200

    All tests compile

commit f21bc5c
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 27 08:31:04 2023 +0200

    Working add11_yml.rs

commit 4e2b3f3
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 18:50:32 2023 +0200

    Modify add11_yml.rs

commit c324412
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 18:28:21 2023 +0200

    Working test_simple_transfer

commit df55e45
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 08:54:24 2023 +0200

    Add insert test for storage trie

commit ca0102f
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 08:42:03 2023 +0200

    Minor

commit dc27351
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Thu Oct 26 08:40:57 2023 +0200

    Working insert

commit f6c4067
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 25 08:07:31 2023 +0200

    Fix hash

commit c6e85eb
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 18:46:32 2023 +0200

    Minor

commit d95c430
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 18:32:05 2023 +0200

    Working smt hashing

commit fd09915
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 14:32:38 2023 +0200

    Progress

commit a706cda
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Wed Oct 18 07:37:26 2023 +0200

    Progress

commit 95e5cc1
Author: wborgeaud <williamborgeaud@gmail.com>
Date:   Fri Oct 13 09:19:45 2023 +0200

    Add SMT types

* Constrain uninitialized memory to 0 (#1318)

* Fix typos in comments

* Fix typos in comments

* Add test for ERC20 transfer (#1331)

* Working test

* Minor

* Cleaning

* Implement storage SMT

* Working ERC20 test

* Cleaning

* Remove `len` column in `KeccakSpongeStark` (#1334)

* Remove len column in KeccakSpongeStark

* Apply comment

Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>

---------

Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>

* Add withdrawals (#1322)

* Withdrawals

* Remove AllRecursiveCircuits in withdrawals test

* Fix ERC20 test

* Add memory checks for prover_input, as well as range_checks for prover_input, syscalls/exceptions (#1168)

* Add memory checks for prover_input and range_checks for prover_input, syscalls and exceptions

* Replace u32 by U256, and remove extra CTLs

* Add column in ArithmeticStark to use ctl_arithmetic_base_rows for is_range_check

* Fix CTLs and circuit constraint.

* Fix CTLs

* restore `no-std` support (#1335)

* perform test action on `x86_64-unknown-linux-gnu` and `wasm32-unknown-unknown`

Signed-off-by: muraca <mmuraca247@gmail.com>

* make `plonky2` build on `wasm32-unknown-unknown`

Signed-off-by: muraca <mmuraca247@gmail.com>

* make `starky` build on `wasm32-unknown-unknown`
small oversight on `plonky2` fixed

Signed-off-by: muraca <mmuraca247@gmail.com>

* skip `evm` folder if target is `wasm32-unknown-unknown`

Signed-off-by: muraca <mmuraca247@gmail.com>

* add `default: true` to toolchain

Signed-off-by: muraca <mmuraca247@gmail.com>

* skip `test` if target is `wasm32-unknown-unknown`

Signed-off-by: muraca <mmuraca247@gmail.com>

* single ticks instead of double

Signed-off-by: muraca <mmuraca247@gmail.com>

* explicit target

Signed-off-by: muraca <mmuraca247@gmail.com>

* wasm32 job

Signed-off-by: muraca <mmuraca247@gmail.com>

* added `--no-default-features` to checks

Signed-off-by: muraca <mmuraca247@gmail.com>

---------

Signed-off-by: muraca <mmuraca247@gmail.com>

* Fix create_contract_account

* Fixes

* More fixes

* More fixes

* Minor

---------

Signed-off-by: muraca <mmuraca247@gmail.com>
Co-authored-by: Paul Gebheim <pgebheim@gmail.com>
Co-authored-by: Hamy Ratoanina <hamy.ratoanina@toposware.com>
Co-authored-by: shuoer86 <129674997+shuoer86@users.noreply.github.com>
Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
Co-authored-by: Linda Guiga <101227802+LindaGuiga@users.noreply.github.com>
Co-authored-by: Matteo Muraca <56828990+muraca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants