Add try_build_with_options #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
puma314
approved these changes
Nov 29, 2023
muursh
reviewed
Nov 30, 2023
| pub fn try_build_with_options<C: GenericConfig<D, F = F>>( | ||
| mut self, | ||
| commit_to_sigma: bool, | ||
| ) -> (CircuitData<F, C, D>, bool) { |
There was a problem hiding this comment.
Using Result<> rather than a bool would be more rusty.
muursh
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using cyclic recursion,
CircuitBuilder::build_with_optionscurrently checks that the resulting common data matches the data that was passed intoCircuitBuilder::conditionally_verify_cyclic_proof, and panics if it's different. This PR adds atry_build_with_optionsfunction that always returns the data along with a boolean of whether it succeeded or not. This way, it's possible to get the correct common_data and pass it intoconditionally_verify_cyclic_proof. The behavior ofbuild_with_optionsis the same.