Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Default and Eq where possible #1565

Conversation

matthiasgoergens
Copy link
Contributor

We can't use Rust's default deriving mechanism, until rust-lang/rust#26925 and rust-lang/rust#7671 are fixed.

But fortunately, there's a crate for that.

We can't use Rust's default deriving mechanism, until
rust-lang/rust#26925 and
rust-lang/rust#7671 are fixed.

But fortunately, there's a crate for that.
Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really in favor of these changes. I don't see the problem of having a few custom implementations of Default or Eq, especially if it prevents including an additional dependency that hasn't been maintained for the past 3 years.

Is the current implementation problematic in any way for your usecase?

@matthiasgoergens
Copy link
Contributor Author

You are right that the crate hasn't been updated in a while.

Well, I hope the Rust compiler gets fixed at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants