Move profile definitions to root workspace toml. #437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a warning about the profiles in the
plonky2/Cargo.toml
file by moving them to the to the top level workspace toml file (this issue probably arose in the recent crate refactor). The profiles themselves just set optimisation levels to the defaults, and so the fact that they were ignored didn't cause any issues.The only concern might be publishing "subcrates", which might not inherit the profile correctly, as described in
rust-lang/cargo#8264.