Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip circuit config / regeneration with test_only feature #288

Closed
Nashtare opened this issue Jun 5, 2024 · 0 comments
Closed

Skip circuit config / regeneration with test_only feature #288

Nashtare opened this issue Jun 5, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Nashtare
Copy link
Collaborator

Nashtare commented Jun 5, 2024

The test_only feature allows us to skip actual proof generation and quickly test:

  • the decoder behavior
  • the witness generation

With an emphasis on the latter for debugging, by toggling RUST_LOG to the lowest level.
As such, we don't need any preprocessed circuits the prover may have generated. Since the circuit consistency work has been merged, this has us wiping out the whole circuits/ folder and rewrite new ones (usually set with minimal ranges for speed).

We could actually skip this step altogether, and take the existing circuits as they are, as they won't be at use anyway.
This, combined with a default use of --load-stragegy on-demand upon activation of the test_only flag would remove all needless overhead from preprocessing when testing / debugging, maintain low memory usage, and allow to persist the existing set of circuits (if any) on disk for later use.

@Nashtare Nashtare added the enhancement New feature or request label Jun 5, 2024
@Nashtare Nashtare transferred this issue from 0xPolygonZero/zero-bin Jun 18, 2024
@Nashtare Nashtare added this to the Cleanups and Misc. milestone Jun 27, 2024
@Nashtare Nashtare modified the milestones: Misc., Performance Tuning Jul 12, 2024
@Nashtare Nashtare moved this from Backlog to Todo in Zero EVM Aug 13, 2024
@hratoanina hratoanina self-assigned this Aug 16, 2024
@hratoanina hratoanina moved this from Todo to In Progress in Zero EVM Aug 16, 2024
@hratoanina hratoanina moved this from In Progress to Ready to Review in Zero EVM Aug 21, 2024
@hratoanina hratoanina moved this from Ready to Review to Done in Zero EVM Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants